You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/09 17:27:58 UTC
[GitHub] [iceberg] RussellSpitzer opened a new pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
RussellSpitzer opened a new pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078
Made core pr of this Docs PR
https://github.com/apache/iceberg-docs/pull/48/files
Basically our issue is that the current quick-start commands to do not work with the now default download method of spark "3.2" so I updated the references so they use the correct artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1034105334
Do we intend to merge the PRs both here and in the docs repo? @samredai @RussellSpitzer
I am thinking we can just merge the PR here, and I can run a "release" later in the doc repo, that helps me verify the doc release script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai edited a comment on pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
samredai edited a comment on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1035627957
@RussellSpitzer yes you can merge both of these. That will auto-deploy the fix to the common page but we'll need to update the `0.13.0` branch in `apache/iceberg-docs` in order to fix that docs site (each version site is deployed separately). So a cherry-pick of the commits in the [iceberg-docs PR](https://github.com/apache/iceberg-docs/pull/48) from `main` to `0.13.0` should be the only thing left to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai edited a comment on pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
samredai edited a comment on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1034084999
This LGTM. Merging the other PR will deploy the fix to the "How To Verify a Release" page. I can follow-up there with the PR to patch the 0.13.0 docs site (meaning the `0.13.0` branch) with these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803019175
##########
File path: docs/versioned/api/java-api.md
##########
@@ -251,6 +251,8 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-spark2` is an implementation of Spark's Datasource V2 API in 2.4 for Iceberg (use iceberg-spark-runtime for a shaded version)
* `iceberg-spark3` is an implementation of Spark's Datasource V2 API in 3.0 for Iceberg (use iceberg-spark3-runtime for a shaded version)
+* `iceberg-spark-3.1` is an implementation of Spark's Datasource V2 API in 3.1 for Iceberg (use iceberg-spark-3.1-runtime for a shaded version)
+* `iceberg-spark-3.2` is an implementation of Spark's Datasource V2 API in 3.2 for Iceberg (use iceberg-spark-3.2-runtime for a shaded version)
Review comment:
I thought these were `iceberg-spark-runtime-3.x`.
See here: https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark-runtime-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803019175
##########
File path: docs/versioned/api/java-api.md
##########
@@ -251,6 +251,8 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-spark2` is an implementation of Spark's Datasource V2 API in 2.4 for Iceberg (use iceberg-spark-runtime for a shaded version)
* `iceberg-spark3` is an implementation of Spark's Datasource V2 API in 3.0 for Iceberg (use iceberg-spark3-runtime for a shaded version)
+* `iceberg-spark-3.1` is an implementation of Spark's Datasource V2 API in 3.1 for Iceberg (use iceberg-spark-3.1-runtime for a shaded version)
+* `iceberg-spark-3.2` is an implementation of Spark's Datasource V2 API in 3.2 for Iceberg (use iceberg-spark-3.2-runtime for a shaded version)
Review comment:
I thought these were `iceberg-spark-runtime-3.x`. Did we not make that change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1034084999
This LGTM. Merging the other PR will deploy the fix to the "How To Verify a Release" page. I can follow-up there with the PR to patch the 0.13.0 docs site (meaning the `0.13.0` branch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1035627957
@RussellSpitzer yes you can merge both of these. That will auto-deploy the fix to the common page but we'll need to update the `0.13.0` branch in `apache/iceberg-docs` in order to fix that docs site (each version site is deployed separately). So a cherry-pick of this commit from `main` to `0.13.0` should be the only thing left to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1034110020
@jackye1995 I like that idea. And yes the changes will need to make it over to the `iceberg-docs` repo but I agree that making the changes there should be considered as part of a release and not the responsibility of the person opening the PR here against `apache/iceberg` (in this case Russell).
I'd consider this as a "between versions hot-fix" of the common site and the `0.13.0` docs site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803020663
##########
File path: docs/versioned/integrations/jdbc.md
##########
@@ -45,7 +45,7 @@ the JDBC catalog allows arbitrary configurations through:
You can start a Spark session with a MySQL JDBC connection using the following configurations:
```shell
-spark-sql --packages org.apache.iceberg:iceberg-spark3-runtime:{{% icebergVersion %}} \
+spark-sql --packages org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:{{% icebergVersion %}} \
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1036438288
Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803022099
##########
File path: docs/versioned/api/java-api.md
##########
@@ -251,6 +251,8 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-spark2` is an implementation of Spark's Datasource V2 API in 2.4 for Iceberg (use iceberg-spark-runtime for a shaded version)
* `iceberg-spark3` is an implementation of Spark's Datasource V2 API in 3.0 for Iceberg (use iceberg-spark3-runtime for a shaded version)
+* `iceberg-spark-3.1` is an implementation of Spark's Datasource V2 API in 3.1 for Iceberg (use iceberg-spark-3.1-runtime for a shaded version)
+* `iceberg-spark-3.2` is an implementation of Spark's Datasource V2 API in 3.2 for Iceberg (use iceberg-spark-3.2-runtime for a shaded version)
Review comment:
Also, maybe we shouldn't put the information about which jar to use in parentheses? Seems to me like it downplays it and we'll get questions about "why isn't this iceberg-spark-3.1 jar working?". But that's less important than just updating these two to have the correct artifact name 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4078: [Docs] Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803019175
##########
File path: docs/versioned/api/java-api.md
##########
@@ -251,6 +251,8 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-spark2` is an implementation of Spark's Datasource V2 API in 2.4 for Iceberg (use iceberg-spark-runtime for a shaded version)
* `iceberg-spark3` is an implementation of Spark's Datasource V2 API in 3.0 for Iceberg (use iceberg-spark3-runtime for a shaded version)
+* `iceberg-spark-3.1` is an implementation of Spark's Datasource V2 API in 3.1 for Iceberg (use iceberg-spark-3.1-runtime for a shaded version)
+* `iceberg-spark-3.2` is an implementation of Spark's Datasource V2 API in 3.2 for Iceberg (use iceberg-spark-3.2-runtime for a shaded version)
Review comment:
I thought these were `iceberg-spark-runtime-3.x`. The `(use iceberg-spark-3.1-runtime ...)` looks backwards.
See here: https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-spark-runtime-3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#discussion_r803832068
##########
File path: docs/versioned/api/java-api.md
##########
@@ -251,6 +251,8 @@ This project Iceberg also has modules for adding Iceberg support to processing e
* `iceberg-spark2` is an implementation of Spark's Datasource V2 API in 2.4 for Iceberg (use iceberg-spark-runtime for a shaded version)
* `iceberg-spark3` is an implementation of Spark's Datasource V2 API in 3.0 for Iceberg (use iceberg-spark3-runtime for a shaded version)
+* `iceberg-spark-3.1` is an implementation of Spark's Datasource V2 API in 3.1 for Iceberg (use iceberg-spark-3.1-runtime for a shaded version)
+* `iceberg-spark-3.2` is an implementation of Spark's Datasource V2 API in 3.2 for Iceberg (use iceberg-spark-3.2-runtime for a shaded version)
Review comment:
Woops bad copy paste from my cli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078#issuecomment-1035610865
@samredai So should I merge these two PR's now or do I need to do something else to fit into the release structure? Sorry I wasn't sure on the "hotfix" path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer merged pull request #4078: Docs: Update Release Artifacts in Quickstart Commands for Spark
Posted by GitBox <gi...@apache.org>.
RussellSpitzer merged pull request #4078:
URL: https://github.com/apache/iceberg/pull/4078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org