You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/12/19 10:18:13 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3778: Endless
settings on templates and instances
Spaceman1984 opened a new pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778
## Description
<!--- Describe your changes in detail -->
When loading the vm template settings from the ui, if there are more than twelve items in the list, the settings are loaded again if you scroll to the last setting.
This fixes the reload of the settings when scrolling to the end of the list.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Fixes: #3544
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This was tested by going to the settings tab of an instance and a template and adding many settings then navigating away and back and then scrolling down.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778:
Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
Isn't this supposed to be inside dataProvider @DaanHoogland ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778:
Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445086
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
Can you fix indentation @Spaceman1984 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request
#3778: Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r362483040
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
The indentation is fine when viewing with vscode and intellij, I think this is a github display issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778:
Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
Isn't this supposed to be inside dataProvider @DaanHoogland ? So should be more right aligned?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778:
Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445185
##########
File path: ui/scripts/templates.js
##########
@@ -2489,6 +2489,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'Template',
dataProvider: function(args) {
+ // no paging for listTemplates details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3778: Endless
settings on templates and instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#issuecomment-572060222
ui issue and 2 approvals, will merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3778: Endless
settings on templates and instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#issuecomment-571591977
@borisstoyanov if you agree i'll merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3778: Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579718
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
What do you mean @anuragaw ? I see no problem with the indentation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3778: Endless settings on
templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on issue #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#issuecomment-571615901
I've fixed indentation on the PR and LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778:
Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r363777178
##########
File path: ui/scripts/instances.js
##########
@@ -3437,6 +3437,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'UserVm',
dataProvider: function(args) {
+ // no paging for listVirtualMachines details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
What you see in IDEs is actually rendered as per configuration of whitespace. However, this is old UI and I've seen this broken at many files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3778: Endless settings on templates and instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579834
##########
File path: ui/scripts/templates.js
##########
@@ -2489,6 +2489,13 @@
custom: cloudStack.uiCustom.granularDetails({
resourceType: 'Template',
dataProvider: function(args) {
+ // no paging for listTemplates details
+ if (args.page > 1){
+ args.response.success({
+ data: []
+ });
+ return;
+ }
Review comment:
or here?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3778: Endless
settings on templates and instances
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3778: Endless settings on templates and instances
URL: https://github.com/apache/cloudstack/pull/3778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services