You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "koushiro (via GitHub)" <gi...@apache.org> on 2026/01/30 12:00:11 UTC
[PR] refactor(services/obs): migrate obs to reqsign-core v2 [opendal]
koushiro opened a new pull request, #7169:
URL: https://github.com/apache/opendal/pull/7169
# Which issue does this PR close?
Part of #6553
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
# AI Usage Statement
Codex GPT-5.2 high
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/obs): migrate obs to reqsign-core v2 [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #7169:
URL: https://github.com/apache/opendal/pull/7169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/obs): migrate obs to reqsign-core v2 [opendal]
Posted by "koushiro (via GitHub)" <gi...@apache.org>.
koushiro commented on code in PR #7169:
URL: https://github.com/apache/opendal/pull/7169#discussion_r2745937012
##########
core/services/obs/src/backend.rs:
##########
@@ -169,28 +175,27 @@ impl Builder for ObsBuilder {
};
debug!("backend use endpoint {}", &endpoint);
- let mut cfg = HuaweicloudObsConfig::default();
- // Load cfg from env first.
- cfg = cfg.from_env();
+ let ctx = Context::new()
+ .with_file_read(TokioFileRead)
+ .with_http_send(ReqwestHttpSend::new(GLOBAL_REQWEST_CLIENT.clone()))
+ .with_env(OsEnv);
- if let Some(v) = self.config.access_key_id {
- cfg.access_key_id = Some(v);
- }
+ let mut provider = ProvideCredentialChain::new().push(EnvCredentialProvider::new());
- if let Some(v) = self.config.secret_access_key {
- cfg.secret_access_key = Some(v);
+ if let (Some(ak), Some(sk)) = (&self.config.access_key_id, &self.config.secret_access_key) {
+ let static_provider = StaticCredentialProvider::new(ak, sk);
Review Comment:
BTW, do we need to add `security_token` to ObsConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(services/obs): migrate obs to reqsign-core v2 [opendal]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on PR #7169:
URL: https://github.com/apache/opendal/pull/7169#issuecomment-3942835440
<!-- Answer -->
**Related Documentation**
Checked 0 published document(s) in 1 knowledge base(s). No updates required.
<!-- Dosu Comment Footer -->
<sup>How did I do? Any feedback?</sup> [](https://go.dosu.dev/discord-bot)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org