[GitHub] matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #537: Maven Indexing Optimizations
URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187371338
 
 

 ##########
 File path: maven.indexer/src/org/netbeans/modules/maven/indexer/MatchWords.java
 ##########
 @@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.maven.indexer;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.function.Predicate;
+
+/**
+ * Fast test for matching any of a set of prefixes, iterating the characters of
+ * the passed string only once. Borrowed from
+ * https://github.com/timboudreau/bunyan-java/blob/master/bunyan-parse/src/main/java/com/mastfrog/bunyan/parse/MatchWords.java
 
 Review comment:
   It would be better if the comment would be removed. We learned in past in releases, that IPMC reviewers tend to be picky and don't look further as the obvious and could reject the file based on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists