You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/20 07:12:01 UTC
[GitHub] [airflow] Bowrna opened a new pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Bowrna opened a new pull request #19100:
URL: https://github.com/apache/airflow/pull/19100
Pyenv related docs - macOS Big Sur pyenv issue can be fixed by adding commands into ~/.zshrc file
Having AIRFLOW_HOME and Source code in ${HOME} can lead to disastrous effect of deleting all the file in the Airflow folder. Added a warning message to prevent deletion
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949508889
@potiuk I tried to add it in docs/spelling_wordlist.txt and in pre-commit check it fails
```
Run codespell to check for common misspellings in files..................................Failed
- hook id: codespell
- exit code: 65
docs/spelling_wordlist.txt:344: Sur ==> Sure, sir
```
How could I handle it? Also, could I add better instructions in relevant docs when spell check fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949762110
@ephraimbuddy I have to add this change in `.pre-commit-config.yaml` file, am i right? Or do i have to put some instruction in doc about this? Can you please tell me?
Also do i have to add that as part of this PR or do i have to raise a separate PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949922236
> I think (not sure - on my phone now) this is either a codespell flag to add custom error message or pre-commit message. I t should end up with moditlfying the precommit config. And yeah it should be separate commit/pr
I checked and there's no flag. What I tried that worked is :
```
entry: bash -c 'echo "If you think that this failure is an error, consider adding the word(s)
to the codespell dictionary at docs/spelling_wordlist.txt.
The word(s) should be in small letters." && exec codespell "$@"' --
```
Since this is a small change, I'm thinking we should add it here and update the commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#discussion_r732787768
##########
File path: breeze
##########
@@ -283,6 +283,12 @@ function breeze::initialize_virtualenv() {
echo
echo "Wiping and recreating ${AIRFLOW_HOME_DIR}"
echo
+ if [[ "${AIRFLOW_SOURCES}" = "${AIRFLOW_HOME_DIR}" ]]; then
Review comment:
I think you need == here otherwise it is assignment not comparision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949598850
Just checked and it's a simple change to add. Feel free to add it. Just a message to say that users should add the word to spelling_wordlist when there's an error from the hook
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950037782
Got it. let me fix it and raise a different PR. Do I need to make any changes to this PR further? If yes, please let me know. Thanks for all the clarification @ephraimbuddy @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949923778
Result:
```
Run codespell to check for common misspellings in files..................................Failed
- hook id: codespell
- exit code: 65
If you think that this failure is an error, consider adding the word(s) to the codespell dictionary at docs/spelling_wordlist.txt. The word(s) should be in small letters.
docs/apache-airflow/concepts/cluster-policies.rst:25: Sur ==> Sure, sir
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#discussion_r732699219
##########
File path: breeze
##########
@@ -283,6 +283,13 @@ function breeze::initialize_virtualenv() {
echo
echo "Wiping and recreating ${AIRFLOW_HOME_DIR}"
echo
+ SCRIPTPATH="$( cd -- "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 ; pwd -P )"
+ if [ "${SCRIPTPATH}" = "${AIRFLOW_HOME_DIR}" ]; then
Review comment:
We prefer [[ ]] over [] - generally we try to follow Google she guide - you can read more on why [[]] is better https://google.github.io/styleguide/shellguide.html#test----and---
##########
File path: breeze
##########
@@ -283,6 +283,13 @@ function breeze::initialize_virtualenv() {
echo
echo "Wiping and recreating ${AIRFLOW_HOME_DIR}"
echo
+ SCRIPTPATH="$( cd -- "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 ; pwd -P )"
+ if [ "${SCRIPTPATH}" = "${AIRFLOW_HOME_DIR}" ]; then
+ echo "AIRFLOW_HOME and Source code for Apache Airflow resides in the same path ${AIRFLOW_HOME_DIR}"
+ echo "When running this command it will delete all the files in the path ${AIRFLOW_HOME_DIR} to clear dynamic files like config/logs/db"
+ echo "Move your source code for Apache Airflow to different folder to avoid deletion"
+ exit 0
Review comment:
Exit should be with error code (exit 1 is fine)
##########
File path: breeze
##########
@@ -283,6 +283,13 @@ function breeze::initialize_virtualenv() {
echo
echo "Wiping and recreating ${AIRFLOW_HOME_DIR}"
echo
+ SCRIPTPATH="$( cd -- "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 ; pwd -P )"
Review comment:
We already have AIRFLOW_SOURCES that we can use here (see beginning of the breeze script).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-948800793
Some static checks are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy edited a comment on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy edited a comment on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949524712
For now, @Bowrna , add `sur` in small letters to docs/spelling_wordlist.txt, I'm trying to improve the message. It looks more complex to do, so no worries about it
> @potiuk I tried to add it in docs/spelling_wordlist.txt and in pre-commit check it fails
>
> ```
> Run codespell to check for common misspellings in files..................................Failed
> - hook id: codespell
> - exit code: 65
>
> docs/spelling_wordlist.txt:344: Sur ==> Sure, sir
> ```
>
> How could I handle it? Also, could I add better instructions in relevant docs when spell check fails?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949495516
I think you might need to add exception to docs/spelling_wordlist.txt
@ephraimbuddy i think we need to add some better instructions what to do when spell check fails :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna edited a comment on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna edited a comment on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950138865
@ephraimbuddy I have some doubts about the below command:
```
entry: bash -c 'echo "If you think that this failure is an error, consider adding the word(s)
to the codespell dictionary at docs/spelling_wordlist.txt.
The word(s) should be in small letters." && exec codespell "$@"' --
```
why do we have to pass this as bash -c command rather than directly passing
```
echo "If you think that this failure is an error, consider adding the word(s)
to the codespell dictionary at docs/spelling_wordlist.txt.
The word(s) should be in small letters." && exec codespell "$@"
```
Also why does codespell should have "$@" for accessing arguments? Previously enty had only `codespell` in it. That's why i want to clarify. Thank you so much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950270763
> @ephraimbuddy I have some doubts about the below command:
>
> ```
> entry: bash -c 'echo "If you think that this failure is an error, consider adding the word(s)
> to the codespell dictionary at docs/spelling_wordlist.txt.
> The word(s) should be in small letters." && exec codespell "$@"' --
> ```
>
> why do we have to pass this as bash -c command rather than directly passing
>
> ```
> echo "If you think that this failure is an error, consider adding the word(s)
> to the codespell dictionary at docs/spelling_wordlist.txt.
> The word(s) should be in small letters." && exec codespell "$@"
> ```
>
> Also why does codespell should have "$@" for accessing arguments? Previously enty had only `codespell` in it. That's why i want to clarify. Thank you so much :)
We are using ` bash -c` command because the entry point tells pre-commit what to run and here, instead of a custom hook, I want to write bash script directly. The `-c` helps in this by wrapping the whole command in strings.
The "$@" will help bash take arguments from `args:` which pre-commit will pass to it.
We can't do what you suggested because the arguments won't be parsed correctly by pre-commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950311191
Thank you so much @ephraimbuddy for clarifying my doubt. I will raise the PR with the command you have suggested. I have verified by testing and it works for me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950311650
@potiuk @ephraimbuddy do I have to fix anything related to this PR for getting it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949874128
I think (not sure - on my phone now) this is either a codespell flag to add custom error message or pre-commit message. I t should end up with moditlfying the precommit config. And yeah it should be separate commit/pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949524712
For now, @Bowrna , add `sur` in small letters to docs/spelling_wordlist.txt, I'm trying to improve the message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-953691414
> There are changes to `airflow/api_connexion` accidentally included. They need to be removed from this PR.
I have done the changes you have suggested @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950022723
> While i am usually tempted to do the same 'yeah small change let's do it together' - learned by experience it might bite back and when i feel i need to add ' ... and this change also does this ...' in commit message it is usually a sign we should split.
>
> There is very little penalty of splitting commits/PR into separate ones.
>
> And yes i often fail myself to follow this advice. i am.ad guilty as anyone of having more than one change In a logical commit. But i do my best to improve :)
Thanks very much, @potiuk. That's very good advice.
Please @Bowrna make a separate PR for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950138865
@ephraimbuddy I have some doubts about the below command:
```
entry: bash -c 'echo "If you think that this failure is an error, consider adding the word(s)
to the codespell dictionary at docs/spelling_wordlist.txt.
The word(s) should be in small letters." && exec codespell "$@"' --
```
why do we have to pass this as bash -c command rather than directly passing
```
echo "If you think that this failure is an error, consider adding the word(s)
to the codespell dictionary at docs/spelling_wordlist.txt.
The word(s) should be in small letters." && exec codespell "$@"
```
Also why does codespell should have "$@" for accessing arguments? Previously enty had only `codespell` in it. That's why i want to clarify. Thank you so much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-949251437
@potiuk One of the static code checks is the spelling error. I have given the macOS version name as `Big Sur`, but the check wants me to fix the spelling for the below line that i have added
`4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc`
```
Run codespell to check for common misspellings in files..................................Failed
- hook id: codespell
- exit code: 65
CONTRIBUTORS_QUICK_START.rst:150: Sur ==> Sure, sir
```
How could I handle this error? Can you guide me on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-950310251
Precisely that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-947618686
Changes updated as recommended @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19100:
URL: https://github.com/apache/airflow/pull/19100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19100: pyenv related docs added, warning message in breeze initialize-local-virtualenv command
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19100:
URL: https://github.com/apache/airflow/pull/19100#issuecomment-953050545
There are changes to `airflow/api_connexion` accidentally included. They need to be removed from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org