You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/15 14:38:12 UTC
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1995: arch: Add custom arch chip build support
Ouss4 commented on a change in pull request #1995:
URL: https://github.com/apache/incubator-nuttx/pull/1995#discussion_r505595071
##########
File path: boards/Makefile
##########
@@ -110,19 +111,24 @@ endif
depend: .depend
-$(DUMMY_KCONFIG): $(BOARD_KCONFIG)
- $(call DELFILE, $(DUMMY_KCONFIG))
- $(call COPYFILE, $(BOARD_KCONFIG), $(DUMMY_KCONFIG))
+$(DUMMY_BOARD_KCONFIG): $(BOARD_KCONFIG)
+ $(call DELFILE, $(DUMMY_BOARD_KCONFIG))
+ $(call COPYFILE, $(BOARD_KCONFIG), $(DUMMY_BOARD_KCONFIG))
-dirlinks: $(DUMMY_KCONFIG)
+$(DUMMY_CHIP_KCONFIG): $(CHIP_KCONFIG)
+ $(call DELFILE, $(DUMMY_CHIP_KCONFIG))
+ $(call COPYFILE, $(CHIP_KCONFIG), $(DUMMY_CHIP_KCONFIG))
-context: $(DUMMY_KCONFIG)
+dirlinks: $(DUMMY_BOARD_KCONFIG) $(DUMMY_CHIP_KCONFIG)
+
+context: $(DUMMY_BOARD_KCONFIG) $(DUMMY_CHIP_KCONFIG)
Review comment:
Is this the right place to add an arch context operation? These two (board and arch context) are similar but two different operations.
I added a way to include arch into `context` but it's stranded inside #1893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org