[GitHub] [jena] Aklakan edited a comment on pull request #1063: JENA-2154: Custom SERVICE executors

[GitBox <gi...@apache.org>]

Aklakan edited a comment on pull request #1063:
URL: https://github.com/apache/jena/pull/1063#issuecomment-912442963


   A couple of remarks which you probably want to comment on:
   
   * The rationale for the supplier indirection is to defer starting the actual execution. This - in principle - allows for checking which of the executor factories could handle the arguments without immediately starting the execution.
   ```java
   class ServiceExecutorFactory {
     Supplier<QueryIterator> createExecutor(OpService op, Binding binding, ExecutionContext execCxt);
   }
   ```
   One could also use separate 'boolean canExecute()' and 'execute()' methods, however, with that pattern it sometimes happens that `canDoX()` and `doX()` need to internally perform redundant computations.
   
   * Probably it is indeed better to move the code from QueryIterService to Service - but add the 'Binding' argument to the function in Service
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org