[jira] [Commented] (FLUME-1892) IRC Sink NPE

["Ashish Paliwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824449#comment-13824449 ] 

Ashish Paliwal commented on FLUME-1892:
---------------------------------------

Gentle reminder to help with Review

> IRC Sink NPE
> ------------
>
>                 Key: FLUME-1892
>                 URL: https://issues.apache.org/jira/browse/FLUME-1892
>             Project: Flume
>          Issue Type: Bug
>          Components: Docs, Sinks+Sources
>    Affects Versions: v1.4.0
>         Environment: Ubuntu 12.10
>            Reporter: Jeff Collell
>            Assignee: Ashish Paliwal
>            Priority: Minor
>              Labels: patch
>         Attachments: FLUME-1281-1892-0.patch
>
>
> IRCSink.java does not initialize splitlines to a default value if it is not contained in the config. It does check if splitChars is NULL, and initialize it to the default constant, but it does not do so for splitlines.
> The user guide found [here|http://flume.apache.org/FlumeUserGuide.html#irc-sink] does show that splitlines has no default value, but it is not bold (indicating it must be defined in the config).
> Obviously if splitlines is not configured, you'll get a NPE when sendLine is called, since it does not check for NULL values either.



--
This message was sent by Atlassian JIRA
(v6.1#6144)