You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/17 08:41:22 UTC
[GitHub] [flink] snuyanzin commented on a diff in pull request #21150: [FLINK-30056][connectors][kafka] Replace deprecated kafka-clients methods
snuyanzin commented on code in PR #21150:
URL: https://github.com/apache/flink/pull/21150#discussion_r1024896571
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaConsumerThread.java:
##########
@@ -258,7 +259,7 @@ public void run() {
// over
if (records == null) {
try {
- records = consumer.poll(pollTimeout);
+ records = consumer.poll(Duration.ofMillis(pollTimeout));
Review Comment:
please let me know if i need to change commit message
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaConsumerThread.java:
##########
@@ -258,7 +259,7 @@ public void run() {
// over
if (records == null) {
try {
- records = consumer.poll(pollTimeout);
+ records = consumer.poll(Duration.ofMillis(pollTimeout));
Review Comment:
please let me know if i need to change commit message or rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org