[GitHub] [solr] HoustonPutman commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #629:
URL: https://github.com/apache/solr/pull/629#issuecomment-1042380759


   This is not extremely relevant to this PR, but it's something I ran into recently and this is an opportune time to bring it up 🙂 
   
   Due to the major refactoring you did earlier, `AddUpdateCommand` provides different id methods than it used to. Would you mind adding some info to the javaDocs for which methods return the document's `id` that can be used to determine the shard to route to? Basically, which id should be used in: `compositeIdRouter.sliceHash(id, doc, null, coll)`? I know some users that were confused by the removal of `getHashableId()` when trying to update custom plugins. I gave my best guess, but I'd prefer it included in the javaDocs since it seems like a good thing to explicitly call out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org