You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/01/25 13:13:57 UTC

[GitHub] [jmeter] sseide opened a new pull request #695: update tika-parsers, jackson and jsoup

sseide opened a new pull request #695:
URL: https://github.com/apache/jmeter/pull/695


   ## Description
   <!--- Provide a general summary of your changes in the Title above -->
   <!--- Describe your changes in detail here -->
   This PR updates dependencies to fix open security warnings.
   
   ## Motivation and Context
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   * update jackson to 2.13.1 (https://github.com/FasterXML/jackson-databind/issues/3328) and set to same version as tika-parsers
   * update jsoup to 1.14.3 (CVE-2021-37714) and same version as in tika-parsers too
   * tika-parsers to 1.28, fixes dependent jsoup as well as 
     * commons-compress (CVE-2021-36090, CVE-2021-35517,CVE-2021-35516, CVE-2021-35515)
     * jdom2 (CVE-2021-33813)
   
   Question - the `changes.xml` mentions direct dependency updates only i think. Shall these indirect dependency updates for commons-compress and jdom2 also get an entry there or mention update of tika-parsers only is enough?
   
   ## How Has This Been Tested?
   <!--- Please describe in detail how you tested your changes. -->
   <!--- Include details of your testing environment, tests ran to see how -->
   <!--- your change affects other areas of the code, etc. -->
   
   run `gradlew check` and used updated libs in our installation for some days.
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [x] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] FSchumacher commented on pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #695:
URL: https://github.com/apache/jmeter/pull/695#issuecomment-1025130562


   Thanks for the PR.
   
   @vlsi autogenerating would be fine, but I am fine with current status, too :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] asfgit closed pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #695:
URL: https://github.com/apache/jmeter/pull/695


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] codecov-commenter commented on pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #695:
URL: https://github.com/apache/jmeter/pull/695#issuecomment-1021286252


   # [Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#695](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09d0386) into [master](https://codecov.io/gh/apache/jmeter/commit/85580b49ee2f06505129ebccac5d382e412c58e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85580b4) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/695/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #695   +/-   ##
   =========================================
     Coverage     55.59%   55.59%           
   - Complexity    10336    10337    +1     
   =========================================
     Files          1059     1059           
     Lines         65050    65050           
     Branches       7401     7401           
   =========================================
   + Hits          36163    36165    +2     
   + Misses        26337    26336    -1     
   + Partials       2550     2549    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/695/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvUG9pc3NvblJhbmRvbVRpbWVyLmphdmE=) | `78.37% <0.00%> (+5.40%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85580b4...09d0386](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #695:
URL: https://github.com/apache/jmeter/pull/695#issuecomment-1021354563


   >Shall these indirect dependency updates for commons-compress and jdom2 also get an entry there or mention update of tika-parsers only is enough?
   
   That is a good question.
   
   I guess we might want to "autogenerate" the set of differences based on something like https://github.com/apache/jmeter/blob/85580b49ee2f06505129ebccac5d382e412c58e2/src/dist/src/dist/expected_release_jars.csv
   
   In other words, I would prefer to highlight the diff of all the dependencies (including transitive ones) shipped as a part of the default binary distribution.
   
   However, I am fine with proceeding with any approach for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] vlsi commented on pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #695:
URL: https://github.com/apache/jmeter/pull/695#issuecomment-1021354563


   >Shall these indirect dependency updates for commons-compress and jdom2 also get an entry there or mention update of tika-parsers only is enough?
   
   That is a good question.
   
   I guess we might want to "autogenerate" the set of differences based on something like https://github.com/apache/jmeter/blob/85580b49ee2f06505129ebccac5d382e412c58e2/src/dist/src/dist/expected_release_jars.csv
   
   In other words, I would prefer to highlight the diff of all the dependencies (including transitive ones) shipped as a part of the default binary distribution.
   
   However, I am fine with proceeding with any approach for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [jmeter] codecov-commenter commented on pull request #695: update tika-parsers, jackson and jsoup

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #695:
URL: https://github.com/apache/jmeter/pull/695#issuecomment-1021286252


   # [Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#695](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09d0386) into [master](https://codecov.io/gh/apache/jmeter/commit/85580b49ee2f06505129ebccac5d382e412c58e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85580b4) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/695/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #695   +/-   ##
   =========================================
     Coverage     55.59%   55.59%           
   - Complexity    10336    10337    +1     
   =========================================
     Files          1059     1059           
     Lines         65050    65050           
     Branches       7401     7401           
   =========================================
   + Hits          36163    36165    +2     
   + Misses        26337    26336    -1     
   + Partials       2550     2549    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/695/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvUG9pc3NvblJhbmRvbVRpbWVyLmphdmE=) | `78.37% <0.00%> (+5.40%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [85580b4...09d0386](https://codecov.io/gh/apache/jmeter/pull/695?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org