[GitHub] [doris] SWJTU-ZhangLei commented on a diff in pull request #11396: [Bug](MaterializedView) Fix bug of light schema change do not set right unique id cause MV coredump

[GitBox <gi...@apache.org>]

SWJTU-ZhangLei commented on code in PR #11396:
URL: https://github.com/apache/doris/pull/11396#discussion_r935170809


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/MVColumnItem.java:
##########
@@ -108,6 +108,7 @@ public Column toMVColumn(OlapTable olapTable) throws DdlException {
             Preconditions.checkNotNull(defineExpr != null);
             Column result = new Column(name, type, isKey, aggregationType, ColumnDef.DefaultValue.ZERO, "");
             result.setDefineExpr(defineExpr);
+            result.setUniqueId(olapTable.incAndGetMaxColUniqueId());

Review Comment:
   @ the change will override yours
   
   > > could you try like this in MaterializedViewHandler.java checkAndPrepareMaterializedView()
   > > ```
   > >     for (Column column : rollupSchema) {
   > >         column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE);
   > >     }
   > > ```
   > 
   > Hi, Do you can review #10792? I set uniqid also.
   
    the change will override yours



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org