You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/25 13:05:51 UTC

[GitHub] [camel-k] tadayosi opened a new pull request, #3774: fix(e2e): increase build timeout for native build tests: 40m -> 60m

tadayosi opened a new pull request, #3774:
URL: https://github.com/apache/camel-k/pull/3774

   <!-- Description -->
   
   Attempt to address #3773 
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi merged pull request #3774: fix(e2e): increase build timeout for native build tests: 40m -> 60m (1.10.x)

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3774:
URL: https://github.com/apache/camel-k/pull/3774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] tadayosi commented on pull request #3774: fix(e2e): increase build timeout for native build tests: 40m -> 60m

Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3774:
URL: https://github.com/apache/camel-k/pull/3774#issuecomment-1291483813

   > I think that kind of timeout starts becoming a problem. 2 hours seems to be too long. At least we should try to have the native tests starting before everything else, so, the rest of checks will progress in parallel to this long running one.
   
   With my last commit the native tests `native-it` is already isolated from the rest of `install-it`, so they should run in parallel from the start and should not interfere with each other.
   
   Note that 2 hours is the maximum cap of timeouts. When successful they shouldn't take the full 2 hours but the actual time they need to finish (right now it's ~1h20m). That said, as I explained at https://github.com/apache/camel-k/issues/3715#issuecomment-1267922006, this is what it means to run Quarkus native build tests on GitHub-hosted runners. 
   
   Right now, each native build test requires ~40 mins for a successful run and we already have 2 test cases, so it should take at least 80 mins. If we want to add more native tests the time will grow linearly. If we are not happy with it, either we should abandon the native tests from CI, or isolate the native tests into a dedicated workflow and put and run each test case with a separate job in the workflow. (The latter might be something we can consider in the future.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] squakez commented on pull request #3774: fix(e2e): increase build timeout for native build tests: 40m -> 60m (1.10.x)

Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3774:
URL: https://github.com/apache/camel-k/pull/3774#issuecomment-1291602074

   An alternative could be to have a separated check that run on a nightly basis instead (we can even put beside the nightly releases to force us to look to it when failures happen). We will still have a feedback on early failures, but it won't affect that much the time to build at each PR. We can merge this for now and we can have a follow up discussion to see how to proceed from here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org