You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/05/16 04:26:01 UTC

[GitHub] [fineract] josemakara2 commented on a change in pull request #1734: FINERACT-1345: Fixing support for parameterType reports

josemakara2 commented on a change in pull request #1734:
URL: https://github.com/apache/fineract/pull/1734#discussion_r633039564



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java
##########
@@ -212,7 +212,9 @@ private String getSql(final String name, final String type) {
     }
 
     @Override
-    public String getReportType(final String reportName, final boolean isSelfServiceUserReport) {
+    public String getReportType(final String reportName, final boolean isSelfServiceUserReport, final boolean isParameterType) {
+        if (isParameterType) return "Table";

Review comment:
        Format violations
   `if` construct must use {}'s.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org