You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/14 14:25:49 UTC
[kudu-CR](gh-pages) [site] Fix site building
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11210
to review the following change.
Change subject: [site] Fix site building
......................................................................
[site] Fix site building
- add build and thirdparty to exclude list in Jekyll front matter,
because if switching between master and gh-pages, these remain there and
breaking the builds
- update Gemfile.lock to current releases as json had some conflicting
dependencies. Everything failed with the old Gemfile.lock on a fresh
install bundle install (on MacOS at least).
Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
---
M Gemfile.lock
M _config.yml
2 files changed, 56 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11210/1
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11210
to look at the new patch set (#2).
Change subject: [site] Fix site building
......................................................................
[site] Fix site building
- Add build and thirdparty to exclude list in Jekyll front matter,
because if switching between master and gh-pages, these remain there and
breaking the builds.
- Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
MacOS. The dependencies were updated manually to make sure it still
works on Ruby 1.9.3 on Linux as well.
Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
---
M Gemfile.lock
M _config.yml
2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11210/2
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
[site] Fix site building
- Add build and thirdparty to exclude list in Jekyll front matter,
because if switching between master and gh-pages, these remain there and
breaking the builds.
- Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
MacOS. The dependencies were updated manually to make sure it still
works on Ruby 1.9.3 on Linux as well.
Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Reviewed-on: http://gerrit.cloudera.org:8080/11210
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M Gemfile.lock
M _config.yml
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@9
PS2, Line 9: - Add build and thirdparty to exclude list in Jekyll front matter,
: because if switching between master and gh-pages, these remain there and
: breaking the builds.
> doesn't make this change less useful, but maybe 'git worktree' would be hel
awesome, thanks for the tip, I didn't know about this one!
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13
PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
: MacOS. The dependencies were updated manually to make sure it still
: works on Ruby 1.9.3 on Linux as well.
> maybe we should move this to a Dockerfile soon so that jekyll runs inside d
Good idea, although this fix is still useful I think as a docker container should be more like a convenience feature instead of a dependency. Should I file a JIRA for it?
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 19:43:00 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13
PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
: MacOS. The dependencies were updated manually to make sure it still
: works on Ruby 1.9.3 on Linux as well.
> I'd hope that if we moved to docker we would only support that as the one t
Also a good idea, filed a JIRA for it: https://issues.apache.org/jira/browse/KUDU-2544
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:12:07 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 15:05:33 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11210/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/1//COMMIT_MSG@15
PS1, Line 15: works on Ruby 1.9.3 on Linux as well.
> Did you test these changes on linux too?
I did now, it failed with Ruby 2.0 at least... new revision contains only a few dependency changes, tested it on Linux with Ruby 2.0, according to rubygems it should still work with 1.9.3 as well.
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 17:19:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 2: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 17:48:45 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13
PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
: MacOS. The dependencies were updated manually to make sure it still
: works on Ruby 1.9.3 on Linux as well.
> Good idea, although this fix is still useful I think as a docker container
I'd hope that if we moved to docker we would only support that as the one true way to build docs/site. That way we can freely upgrade our dependencies on jekyll/ruby/whatever without having to worry that it works on every platform. Agreed it doesn't need to block this commit though, was just suggesting it as a way to avoid future pain.
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:09:58 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11210/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/1//COMMIT_MSG@15
PS1, Line 15: install bundle install (on MacOS at least).
Did you test these changes on linux too?
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 16:03:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@9
PS2, Line 9: - Add build and thirdparty to exclude list in Jekyll front matter,
: because if switching between master and gh-pages, these remain there and
: breaking the builds.
doesn't make this change less useful, but maybe 'git worktree' would be helpful for you if you didn't know about it already
http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13
PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on
: MacOS. The dependencies were updated manually to make sure it still
: works on Ruby 1.9.3 on Linux as well.
maybe we should move this to a Dockerfile soon so that jekyll runs inside docker in a consistent environment?
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 18:55:21 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Fix site building
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building
......................................................................
Patch Set 4: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217
Gerrit-Change-Number: 11210
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:01:10 +0000
Gerrit-HasComments: No