[GitHub] [spark] cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL] Migrate ALTER TABLE commands to the new framework

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL] Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r384692786
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
 ##########
 @@ -2194,7 +2194,7 @@ class DataSourceV2SQLSuite
     withTempView("v") {
       sql("create global temp view v as select 1")
       val e = intercept[AnalysisException](sql("COMMENT ON TABLE global_temp.v IS NULL"))
 
 Review comment:
   I think all commands support v1 table: they either have a v1 command, or the v2 command works out of the box thanks to v2 session catalog. We need to add test though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org