[GitHub] [flink] PatrickRen commented on a change in pull request #17519: [FLINK-24368][testutils] Print logs JobManager and TaskManager on STDOUT in Flink container for redirecting to log4j in tests

[GitBox <gi...@apache.org>]

PatrickRen commented on a change in pull request #17519:
URL: https://github.com/apache/flink/pull/17519#discussion_r732640315



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainer.java
##########
@@ -385,6 +385,17 @@ public FlinkContainer build() {
 
         private ImageFromDockerfile buildConfiguredImage(
                 Path workersFile, Path configurationFile, String baseImage) {
+            // Build cluster startup command
+            StringBuilder commandBuilder = new StringBuilder();

Review comment:
       Thanks for the review @fapaul ! This is still working because both `ConsoleAppender` and `RollingFileAppender` are used in `log4j-console.properties`, so the log will still be appended to `flink/log/`.
   
   But I just noticed that `FlinkContainer` implements JUnit 4 style `TestLifecycleAware` interface for listening to test runs and dump logs if the run fails, but this won't work on JUnit 5. I'll have a deeper look into this issue. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org