You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "xxchan (via GitHub)" <gi...@apache.org> on 2023/06/19 20:14:22 UTC
[GitHub] [arrow-rs] xxchan opened a new pull request, #4436: doc: deploy crate docs to GitHub pages
xxchan opened a new pull request, #4436:
URL: https://github.com/apache/arrow-rs/pull/4436
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
arrow-rs has many crates. On doc.rs, we can't go to other crates conveniently.
<img width="642" alt="image" src="https://github.com/apache/arrow-rs/assets/37948597/08114ace-dfac-407e-9ce7-885db2ea1638">
Deploying to GitHub pages can improve the situation
<img width="580" alt="image" src="https://github.com/apache/arrow-rs/assets/37948597/92b6c8be-75bf-46a4-9319-f036c74ef17e">
See it on my fork: https://xxchan.github.io/arrow-rs
https://github.com/xxchan/arrow-rs/actions/workflows/docs.yml
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1608120944
@martin-g did the work in DataFusion via https://github.com/apache/arrow-datafusion/pull/5670 -- maybe that is enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1608094705
Yes, I think we need to do the same thing as in DataFusion
@xxchan would it be possible for you to look into doing so? Aka what is described in https://github.com/apache/arrow-rs/pull/4436#issuecomment-1598815865?
If you don't have time that is also fine, I can revert this change and we can work on it when we do have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1598816156
Thank you @xxchan -- this is very helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] xxchan commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1608105817
There is a ASF INFRA doc, but I have no access to the wiki
https://infra.apache.org/github-pages.html
On Mon, 26 Jun 2023 at 21:20, Andrew Lamb ***@***.***> wrote:
> Yes, I think we need to do the same thing as in DataFusion
>
> @xxchan <https://github.com/xxchan> would it be possible for you to look
> into doing so? Aka what is described in #4436 (comment)
> <https://github.com/apache/arrow-rs/pull/4436#issuecomment-1598815865>?
>
> If you don't have time that is also fine, I can revert this change and we
> can work on it when we do have time
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow-rs/pull/4436#issuecomment-1608094705>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJBQZNII6SHTXLAGJENX3I3XNHOJPANCNFSM6AAAAAAZMLSSII>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1598815865
Another strategy that is used for other arrow projects is to publish the apache site (e.g. https://arrow.apache.org/datafusion/)
This is described in https://github.com/apache/arrow-datafusion/tree/main/docs#release-process
I would be happy to help figure out how to make the process work here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1607378711
Let's merge this and see how it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] xxchan commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1607437792
Oops
<img width="769" alt="image" src="https://github.com/apache/arrow-rs/assets/37948597/22d0cb88-2c1e-4f23-af9a-9c9fdec39794">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] xxchan commented on pull request #4436: doc: deploy crate docs to GitHub pages
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on PR #4436:
URL: https://github.com/apache/arrow-rs/pull/4436#issuecomment-1607571831
Maybe we need to update asf.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org