You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2018/08/27 22:49:25 UTC
[incubator-superset] branch update-annotation-model updated
(7691d96 -> 0a90aed)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch update-annotation-model
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.
from 7691d96 add comma back
new 70116b2 linting
new 0a90aed lint some more
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
superset/views/annotations.py | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
[incubator-superset] 02/02: lint some more
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch update-annotation-model
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit 0a90aed681c146901d7db016767d1dd2a355a17e
Author: Hugh Miles <hm...@lyft.com>
AuthorDate: Mon Aug 27 15:49:09 2018 -0700
lint some more
---
superset/views/annotations.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/superset/views/annotations.py b/superset/views/annotations.py
index ecf3f5c..23d47cd 100644
--- a/superset/views/annotations.py
+++ b/superset/views/annotations.py
@@ -40,7 +40,8 @@ class AnnotationModelView(SupersetModelView, DeleteMixin): # noqa
}
description_columns = {
- 'annotation_metadata': 'This JSON represents any additional metadata this annotation needs to add more context.'
+ 'annotation_metadata': 'This JSON represents any additional metadata this \
+ annotation needs to add more context.'
}
def pre_add(self, obj):
[incubator-superset] 01/02: linting
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch update-annotation-model
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit 70116b26e10870900a2427c87cac952b3105f7c6
Author: Hugh Miles <hm...@lyft.com>
AuthorDate: Mon Aug 27 15:48:48 2018 -0700
linting
---
superset/views/annotations.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/superset/views/annotations.py b/superset/views/annotations.py
index 986b3b2..ecf3f5c 100644
--- a/superset/views/annotations.py
+++ b/superset/views/annotations.py
@@ -22,9 +22,12 @@ class AnnotationModelView(SupersetModelView, DeleteMixin): # noqa
add_title = _('Add Annotation')
edit_title = _('Edit Annotation')
- list_columns = ['layer', 'short_descr', 'start_dttm', 'end_dttm', 'annotation_metadata']
+ list_columns = ['layer', 'short_descr', 'start_dttm', 'end_dttm',
+ 'annotation_metadata']
edit_columns = [
- 'layer', 'short_descr', 'long_descr', 'start_dttm', 'end_dttm', 'annotation_metadata']
+ 'layer', 'short_descr', 'long_descr', 'start_dttm', 'end_dttm',
+ 'annotation_metadata']
+
add_columns = edit_columns
label_columns = {