You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/05 08:16:35 UTC

[GitHub] [kafka] YeonCheolGit opened a new pull request #11851: MINOR: Reorder keyword in KafkaException.java

YeonCheolGit opened a new pull request #11851:
URL: https://github.com/apache/kafka/pull/11851


   Reorder keyword as familiar Java style in KafkaException.java
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] YeonCheolGit commented on pull request #11851: MINOR: Reorder keyword in KafkaException.java

Posted by GitBox <gi...@apache.org>.
YeonCheolGit commented on pull request #11851:
URL: https://github.com/apache/kafka/pull/11851#issuecomment-1059754596


   @showuon Maybe this is too minor change, but review please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #11851: MINOR: Reorder keyword in KafkaException.java

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11851:
URL: https://github.com/apache/kafka/pull/11851#issuecomment-1059882253


   @YeonCheolGit , thanks for the PR. But I'm wondering if this is a necessary change? In Kafka, we don't force this `final` and `static` order. So, I don't think we have to change this. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] YeonCheolGit closed pull request #11851: MINOR: Reorder keyword in KafkaException.java

Posted by GitBox <gi...@apache.org>.
YeonCheolGit closed pull request #11851:
URL: https://github.com/apache/kafka/pull/11851


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] YeonCheolGit edited a comment on pull request #11851: MINOR: Reorder keyword in KafkaException.java

Posted by GitBox <gi...@apache.org>.
YeonCheolGit edited a comment on pull request #11851:
URL: https://github.com/apache/kafka/pull/11851#issuecomment-1059754596


   @showuon Maybe this is too minor change. But review please 😅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org