[GitHub] WillemJiang commented on a change in pull request #523: [SCB-272] Edge find service instances null problem

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #523: [SCB-272] Edge find service instances null problem
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/523#discussion_r162875750
 
 

 ##########
 File path: swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/converter/AbstractConverter.java
 ##########
 @@ -70,7 +70,10 @@ public JavaType convert(ClassLoader classLoader, String packageName, Swagger swa
 
       return result;
     } catch (IllegalArgumentException e) {
-      LOGGER.info("failed to load generic class, use {}.", result.getGenericSignature(), e);
+      LOGGER.info("failed to load generic class {}, use {}. cause: {}.",
+          rawClassName,
+          result.getGenericSignature(),
+          e.getMessage());
 
 Review comment:
   We can see the stack trace when passing the exception instance into LOGGER.  My suggestion is keeping the e there instead of using e.getMessage().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services