You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 03:50:00 UTC
[jira] [Commented] (FLINK-7775) Remove unreferenced method
PermanentBlobCache#getNumberOfCachedJobs
[ https://issues.apache.org/jira/browse/FLINK-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421917#comment-16421917 ]
ASF GitHub Bot commented on FLINK-7775:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5799
[FLINK-7775] Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs
## What is the purpose of the change
*This pull request remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs*
## Brief change log
- *Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-7775
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5799
----
commit 19d786cdd426302e316df5c24f59e8976a85c108
Author: yanghua <ya...@...>
Date: 2018-04-02T03:46:44Z
[FLINK-7775] Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs
----
> Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs
> -------------------------------------------------------------------
>
> Key: FLINK-7775
> URL: https://issues.apache.org/jira/browse/FLINK-7775
> Project: Flink
> Issue Type: Task
> Components: Local Runtime
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
>
> {code}
> public int getNumberOfCachedJobs() {
> return jobRefCounters.size();
> }
> {code}
> The method of PermanentBlobCache is not used.
> We should remove it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)