You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Potter (JIRA)" <ji...@apache.org> on 2013/09/02 18:32:52 UTC
[jira] [Commented] (CASSANDRA-5969) Allow JVM_OPTS to be passed to
sstablescrub
[ https://issues.apache.org/jira/browse/CASSANDRA-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756161#comment-13756161 ]
Jeff Potter commented on CASSANDRA-5969:
----------------------------------------
Quoting makes sense -- although there are other scripts that already have JVM_OPTS without quotes (bin/cassandra, bin/sstableloader). Let me know if I should revise the patch.
> Allow JVM_OPTS to be passed to sstablescrub
> -------------------------------------------
>
> Key: CASSANDRA-5969
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5969
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: Adam Hattrell
> Assignee: Brandon Williams
>
> Can you add a feature request to pass JVM_OPTS to the sstablescrub script -- and other places where java is being called? (Among other things, this lets us run java stuff with "-Djava.awt.headless=true" on OS X so that Java processes don't pop up into the foreground -- i.e. we have a script that loops over all CFs and runs sstablescrub, and without that flag being passed in the OS X machine becomes pretty much unusable as it keeps switching focus to the java processes as they start.)
>
> --- a/resources/cassandra/bin/sstablescrub
> +++ b/resources/cassandra/bin/sstablescrub
> @@ -70,7 +70,7 @@ if [ "x$MAX_HEAP_SIZE" = "x" ]; then
> MAX_HEAP_SIZE="256M"
> fi
>
> -$JAVA -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
> +$JAVA $JVM_OPTS -ea -cp $CLASSPATH -Xmx$MAX_HEAP_SIZE \
> -Dlog4j.configuration=log4j-tools.properties \
> org.apache.cassandra.tools.StandaloneScrubber "$@"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira