[GitHub] [airflow] wmorris75 commented on a change in pull request #5717: [AIRFLOW-5052] Added the include_deleted params to salesforce make_query

[GitBox <gi...@apache.org>]

wmorris75 commented on a change in pull request #5717: [AIRFLOW-5052] Added the include_deleted params to salesforce make_query
URL: https://github.com/apache/airflow/pull/5717#discussion_r312640035
 
 

 ##########
 File path: airflow/contrib/hooks/salesforce_hook.py
 ##########
 @@ -73,19 +73,23 @@ def get_conn(self):
             )
         return self.conn
 
-    def make_query(self, query):
+    def make_query(self, query, include_deleted=False, **query_params):
         """
         Make a query to Salesforce.
 
         :param query: The query to make to Salesforce.
         :type query: str
+        :param include_deleted: True if the query should include deleted records.
+        :type include_deleted: bool
+        :param query_params: Additional optional arguments
+        :type dict
         :return: The query result.
         :rtype: dict
         """
         conn = self.get_conn()
 
         self.log.info("Querying for all objects")
-        query_results = conn.query_all(query)
+        query_results = conn.query_all(query, include_deleted=include_deleted, **query_params)
 
 Review comment:
   Gotcha.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services