[GitHub] [nifi-registry] thenatog commented on a change in pull request #296: NIFIREG-313 - Add OpenId Connect support for authenticating users

[GitBox <gi...@apache.org>]

thenatog commented on a change in pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#discussion_r470722627



##########
File path: nifi-registry-core/pom.xml
##########
@@ -143,6 +143,17 @@
                 <artifactId>jersey-media-multipart</artifactId>
                 <version>${jersey.server.version}</version>
             </dependency>
+            <!-- open id connect - override transitive dependency version ranges -->
+            <dependency>
+                <groupId>com.nimbusds</groupId>
+                <artifactId>oauth2-oidc-sdk</artifactId>
+                <version>6.16.2</version>
+            </dependency>
+            <dependency>
+                <groupId>com.google.guava</groupId>
+                <artifactId>guava</artifactId>
+                <version>28.0-jre</version>
+            </dependency>

Review comment:
       I'd say yes. Are there any issues with adding this dependency to the core pom? I believe this is used already in NiFi. 
   Guava provides a cache used by the OIDC service.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org