You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "fgerlits (via GitHub)" <gi...@apache.org> on 2023/04/12 12:10:14 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
fgerlits opened a new pull request, #1555:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555
If you try to compile with ENABLE_ALL=ON but with neither ENABLE_PYTHON_SCRIPTING or ENABLE_LUA_SCRIPTING set (so they default to OFF), then the build fails with a "cannot find -lminifi-script-extension: No such file or directory" linker error. This change fixes the error.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1555:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1164058596
##########
extensions/script/CMakeLists.txt:
##########
Review Comment:
I see that there are more extensions where ENABLE_ALL is not take into consideration, should we fix those as well? From what I could gather the extensions where this check is missing are the followings: Bustache, Kubernetes, OPC, OpenCV, OpenWSMAN, PDH, Systemd, Tensorflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1555:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1164492014
##########
extensions/script/CMakeLists.txt:
##########
Review Comment:
I agree, Tensorflow should not be enabled with this flag, it has no bundled libraries and not tested nor built in the CI. If you want to handle the others separately from this issue you can create a separate Jira ticket for it, I'm okay with that too, it's your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1555:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1165117425
##########
extensions/script/CMakeLists.txt:
##########
Review Comment:
I have created Jira https://issues.apache.org/jira/browse/MINIFICPP-2098 as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1555: MINIFICPP-2097 Fix build failure when ENABLE_ALL is ON
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1555:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1555#discussion_r1164462363
##########
extensions/script/CMakeLists.txt:
##########
Review Comment:
That's a different issue, because they don't cause a build failure, unlike this one.
I don't want `ENABLE_ALL` to enable Tensorflow, because that needs special libraries to build, but I can enable the rest of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org