You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/02 11:07:23 UTC

[GitHub] [shardingsphere] RishiKumarRay opened a new pull request, #22596: changed show_resources to show_storage_units.xml

RishiKumarRay opened a new pull request, #22596:
URL: https://github.com/apache/shardingsphere/pull/22596

   Fixes #22589
   
   Changes proposed in this pull request:
     -
     -
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ x] I have self-reviewed the commit code.
   - [ x] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #22596: changed show_resources to show_storage_units.xml

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on PR #22596:
URL: https://github.com/apache/shardingsphere/pull/22596#issuecomment-1337167001

   It's fixed by #22671, so i close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 closed pull request #22596: changed show_resources to show_storage_units.xml

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 closed pull request #22596: changed show_resources to show_storage_units.xml
URL: https://github.com/apache/shardingsphere/pull/22596


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 commented on a diff in pull request #22596: changed show_resources to show_storage_units.xml

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on code in PR #22596:
URL: https://github.com/apache/shardingsphere/pull/22596#discussion_r1038220767


##########
test/integration-test/test-suite/src/test/resources/cases/ral/ral-integration-test-cases.xml:
##########
@@ -82,7 +82,7 @@
         <assertion expected-data-file="show_sharding_table_rule.xml">
             <assertion-sql sql="SHOW SHARDING TABLE RULES" />
         </assertion>
-        <assertion expected-data-file="show_resources.xml">
+        <assertion expected-data-file="show_storage_units.xml">

Review Comment:
   You also need find show_resources file to change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #22596: changed show_resources to show_storage_units.xml

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on PR #22596:
URL: https://github.com/apache/shardingsphere/pull/22596#issuecomment-1336279868

   @RishiKumarRay Hi, there are some conflicts, can you fix it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org