You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/04/20 03:12:28 UTC

[GitHub] [dolphinscheduler] wangxj3 opened a new issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

wangxj3 opened a new issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326


   delete the user ,when query the project by join the table of t_ds_user will return null.
   Suggested that  [
   from t_ds_project p
           join t_ds_user u on p.user_id = u.id
   ]changed  to  [
   from t_ds_project p
          left  join t_ds_user u on p.user_id = u.id
   ]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] fanwq edited a comment on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
fanwq edited a comment on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823107912


   a project can be owned by more than one user, so i think it's better to define user_id as project creator other than owner. Project owners are defined in `t_ds_relation_project_user`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] fanwq commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
fanwq commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823107912


   a project can be owned by more than one user, so i think it's better to define user_id as project creator other than owner. Project owners are defined in `t_ds_relation_process_instance`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-822953349


   I think the best solution is to prevent deleting the user if the user owns a project until the user deletes the project he owns. Otherwise, we will find out that a project does not have an owner, this also cause confusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823119194


   > a project can be owned by more than one user, so i think it's better to define user_id as project creator other than owner. Project owners are defined in `t_ds_relation_project_user`.
   
   I think the project owner should be only one, others just have the permission for the project, the relation is defined in `t_ds_relation_project_user `, and they should not be defined as owner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-822953349


   I think the best solution is to prevent deleting the user if the user owns a project until the user deletes the project he owns or change the owner. Otherwise, we will find out that a project does not have an owner, this also cause confusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823738671


   > when delete the user ,if he is a the owner, chose a new owner form the t_ds_relation_project_user .What do you think of this plan?
   
   Agree, but I think you should let user choose a new owner from `t_ds_user`, because there may not relation in `t_ds_relation_project_user `. And how to interact if there are multiple project belongs to the delete user. 
   
   This kind of problem also exists for `resource` and `processdefinition`, cause by store the `user_id`. This seems to be a large-scale issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-822941084


   Hi:
   * Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
   * In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
   * If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823738671


   > when delete the user ,if he is a the owner, chose a new owner form the t_ds_relation_project_user .What do you think of this plan?
   
   Agree, but I think you should let user choose a new owner from `t_ds_user`, because there may not relation in `t_ds_relation_project_user `. And this kind of problem also exists for `resource` and `processdefinition`, cause by store the `user_id`. This seems to be a large-scale issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] CalvinKirs closed issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823064588


   > The user_id of t_ds_project is the create user id. If we want to delete this user which create this project ,we should delete this project first,but this project may be visible and used by other users.May be functions that can be replaced by project owners is a choice.
   
   Yeal, currently the `user_id` in `t_ds_project` table represents project creator, but I think it might be better to change its meaning to project owner, so that we can provide a method to update the project owner. Otherwise, once we delete the user, the project creator will be null.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] fanwq commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
fanwq commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-822948686


   i have fixed this bug in pr #5327, please review that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] wangxj3 closed issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
wangxj3 closed issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823065463


   @fanwq What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] wangxj3 commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
wangxj3 commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823699540


   when delete the user  ,if he is a  the owner,  chose a new owner form the t_ds_relation_project_user .What do you think of this plan?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun edited a comment on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823119194


   > a project can be owned by more than one user, so i think it's better to define user_id as project creator other than owner. Project owners are defined in `t_ds_relation_project_user`.
   
   I think the project owner should be only one, others just have the permission for the project, the relation is defined in `t_ds_relation_project_user `, and they should not be defined as owner. Or do you have other ways to solve the problem of user being null if we delete the user in the `t_ds_project`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] wangxj3 commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
wangxj3 commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823045876


   The user_id of t_ds_project is the create user id. If we want to delete this user which create this project ,we should delete this project first,but this project may be visible and used by other users.May be functions that can be replaced by project owners is a choice.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-822953349


   I think the best solution is to prevent deleting the user if the user owns a project until the user deletes the project he owns. Otherwise, we will find out that a project does not have an owner, this also cause confusion. Same for resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] wangxj3 commented on issue #5326: [Bug][api-server] delete the user ,when query the project by join the table of t_ds_user will return null.

Posted by GitBox <gi...@apache.org>.
wangxj3 commented on issue #5326:
URL: https://github.com/apache/dolphinscheduler/issues/5326#issuecomment-823744321


   > 
   > 
   > > when delete the user ,if he is a the owner, chose a new owner form the t_ds_relation_project_user .What do you think of this plan?
   > 
   > Agree, but I think you should let user choose a new owner from `t_ds_user`, because there may not relation in `t_ds_relation_project_user `. And how to interact if there are multiple project belongs to the delete user.
   > 
   > This kind of problem also exists for `resource` and `processdefinition`, cause by store the `user_id`. This seems to be a large-scale issue.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org