[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5382: Temporary work-around to bypass function arguments being treated as expressions with columns.

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #5382:
URL: https://github.com/apache/incubator-pinot/pull/5382#discussion_r424826914



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/ServerQueryRequest.java
##########
@@ -94,10 +94,12 @@ public ServerQueryRequest(InstanceRequest instanceRequest, ServerMetrics serverM
     if (aggregationsInfo != null) {
       _aggregationExpressions = new HashSet<>();
       for (AggregationInfo aggregationInfo : aggregationsInfo) {
-        if (!aggregationInfo.getAggregationType().equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
-          for (String expressions : AggregationFunctionUtils.getArguments(aggregationInfo)) {
-            _aggregationExpressions.add(TransformExpressionTree.compileToExpressionTree(expressions));
-          }
+        String aggregationType = aggregationInfo.getAggregationType();

Review comment:
       Yeah, I was debating between the two approaches. I missed that we could support expressions in distinct. Will update to special case theta-sketch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org