You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:56:36 UTC

[GitHub] [yunikorn-k8shim] wilfred-s opened a new pull request, #459: [YUNIKORN-1305] git sha label substitution

wilfred-s opened a new pull request, #459:
URL: https://github.com/apache/yunikorn-k8shim/pull/459

   ### What is this PR for?
   The sha label on the image is not set correctly during local builds and
   as part of the release process.
   
   ### What type of PR is it?
   * [X] - Bug Fix
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1305
   
   ### How should this be tested?
   The image should contain a label called "yunikorn-web-revision" with a sha reference and not empty
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #459: [YUNIKORN-1305] git sha label substitution

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #459:
URL: https://github.com/apache/yunikorn-k8shim/pull/459#issuecomment-1235097265

   The build badge is showing no status, seems to happen sometimes for workflows.
   Not sure if the link should be updated as lots of other repos have done as a workaround ![build badge](https://github.com/apache/yunikorn-k8shim/workflows/Pre-commit%20checks/badge.svg) Maybe we should change to the push to master workflow... might need to reopen YUNIKORN-1302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #459: [YUNIKORN-1305] git sha label substitution

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #459: [YUNIKORN-1305] git sha label substitution
URL: https://github.com/apache/yunikorn-k8shim/pull/459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #459: [YUNIKORN-1305] git sha label substitution

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #459:
URL: https://github.com/apache/yunikorn-k8shim/pull/459#issuecomment-1235017650

   # [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#459](https://codecov.io/gh/apache/yunikorn-k8shim/pull/459?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c085e1) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/1f050c40396513b0b60eec87c6b10b0647fcfbc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f050c4) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #459      +/-   ##
   ==========================================
   - Coverage   67.00%   66.97%   -0.03%     
   ==========================================
     Files          41       41              
     Lines        6767     6767              
   ==========================================
   - Hits         4534     4532       -2     
   - Misses       2062     2064       +2     
     Partials      171      171              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org