You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "daniel-hutao (via GitHub)" <gi...@apache.org> on 2023/04/17 02:20:57 UTC
[GitHub] [incubator-devlake-helm-chart] daniel-hutao opened a new pull request, #112: fix: repair comment error.
daniel-hutao opened a new pull request, #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112
When using the MySQL prepared by DevLake, you can specify a root password to manage the MySQL.
@klesh @matrixji Please take a look. cc @JorgeGar @hezyin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #112: fix: repair comment error.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1511271511
For external MySQL we do not need MySQL root password, we only need the user/pass for the lake database.
But for MySQL server with our helm chart, follow the description by https://hub.docker.com/_/mysql, the MYSQL_ROOT_PASSWORD is mandatory for starting a MySQL instance, so that's why we initially use the parameter `rootPassword ` for user input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] daniel-hutao commented on pull request #112: fix: repair comment error.
Posted by "daniel-hutao (via GitHub)" <gi...@apache.org>.
daniel-hutao commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1512609897
@klesh @matrixji How about leave this pr link in the option comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh merged pull request #112: fix: repair comment error.
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #112: fix: repair comment error.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1512640489
> @klesh @matrixji How about leave this pr link in the option comment?
A good idea before we have more conclusions about it. Maybe we later could learn more from bitnami/mysql's implement or even provide an option for using bitnami/mysql as a subchart directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on pull request #112: fix: repair comment error.
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1512357700
> For external MySQL we do not need MySQL root password, we only need the user/pass for the lake database. But for MySQL server with our helm chart, follow the description by https://hub.docker.com/_/mysql, the MYSQL_ROOT_PASSWORD is mandatory for starting a MySQL instance, so that's why we initially use the parameter `rootPassword ` for user input
Nice, just the way I thought it should be.
The only problem left is how we can convey the idea to our users clearly.
From the current comment, users can not tell what is it for. We should add more context to explain why he needs to fill in the `rootPassword` in the first place, or, he might still fill in an existing `rootPassword` from some database server by mistake, we don't want that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on pull request #112: fix: repair comment error.
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1510790315
I would like to make sure that the `devlake` pod in the helm is NOT using the `rootPassword` for anything, right?
if that so, we should also declare that it is for user to manage the `mysql` instance deployed by our helm and it is NOT required when using external db, like rds...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #112: fix: repair comment error.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1512639919
>
A good idea before we have more conclusions about it. Maybe we later could learn more from bitnami/mysql's implement or even provide an option for using bitnami/mysql as a subchart directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] klesh commented on pull request #112: fix: repair comment error.
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #112:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/112#issuecomment-1514027121
@daniel-hutao @matrixji I think we could add the following comment above the `rootPassword`:
`rootPassword` is used to initialize the Optional MySQL database that ships with our helm, please leave it blank if you are using an external database like RDS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org