You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "fresh-borzoni (via GitHub)" <gi...@apache.org> on 2026/08/24 14:31:22 UTC
[PR] [rust][python] Add LICENSE and NOTICE to the published artifacts [fluss]
fresh-borzoni opened a new pull request, #4090:
URL: https://github.com/apache/fluss/pull/4090
Follow-up to #3803 - the python/crates check I said I'd do separately.
Neither the PyPI wheel/sdist nor the `fluss-rs` .crate carries LICENSE or NOTICE: `git archive` roots at `fluss-rust/` and cargo roots at the crate dir, so neither inherits what #3803 added.
The sdist even bundles the Flink/Kafka/Paimon-derived sources that LICENSE attributes.
Adds both files to `bindings/python` and `crates/fluss`, declares them in `pyproject.toml` (maturin ships them only when `license-files` lists them), and fails the two release workflows if an artifact is missing either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [rust][python] Add LICENSE and NOTICE to the published artifacts [fluss]
Posted by "charlesdong1991 (via GitHub)" <gi...@apache.org>.
charlesdong1991 commented on code in PR #4090:
URL: https://github.com/apache/fluss/pull/4090#discussion_r3846529360
##########
fluss-rust/bindings/python/pyproject.toml:
##########
@@ -16,18 +16,18 @@
# under the License.
[build-system]
-requires = ["maturin>=1.0,<2.0"]
+requires = ["maturin>=1.9,<2.0"]
Review Comment:
dev extra is still >=1.8.2 though, so nice to align
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [rust][python] Add LICENSE and NOTICE to the published artifacts [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on PR #4090:
URL: https://github.com/apache/fluss/pull/4090#issuecomment-5396803813
@leekeiabstraction @charlesdong1991 Appreciate a review, related to release requirements 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [rust][python] Add LICENSE and NOTICE to the published artifacts [fluss]
Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni merged PR #4090:
URL: https://github.com/apache/fluss/pull/4090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org