You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tim Ellison (JIRA)" <ji...@apache.org> on 2009/06/24 13:45:07 UTC
[jira] Resolved: (HARMONY-6242) Math.max(double, double) gives
wrong answer when Math.max(-0.0d, 0.0d)
[ https://issues.apache.org/jira/browse/HARMONY-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6242.
----------------------------------
Resolution: Fixed
Fixed in LUNI module at repo revision r787977, with some regression tests added in r787984.
Please check this fixes the problem for you Ian.
> Math.max(double, double) gives wrong answer when Math.max(-0.0d, 0.0d)
> ----------------------------------------------------------------------
>
> Key: HARMONY-6242
> URL: https://issues.apache.org/jira/browse/HARMONY-6242
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Environment: Any, my test environment is x64 Linux with MRP (http://mrp.codehaus.org/)
> Reporter: Ian Rogers
> Assignee: Tim Ellison
> Fix For: 5.0M11
>
>
> In the code:
> public static double max(double d1, double d2) {
> if (d1 > d2)
> return d1;
> if (d1 < d2)
> return d2;
> /* if either arg is NaN, return NaN */
> if (d1 != d2)
> return Double.NaN;
> /* max( +0.0,-0.0) == +0.0 */
> if (d1 == 0.0 && (d1 != -0.0d || d2 != -0.0d))
> return 0.0;
> return d1;
> }
> This test is never true:
> if (d1 == 0.0 && (d1 != -0.0d || d2 != -0.0d))
> as 0.0 == -0.0 and d2 must be 0.0 or -0.0. This means that in the case of two 0.0 parameters d1 is returned, which is the incorrect behaviour if d2 is 0.0 and d1 -0.0.
> A simple test:
> System.out.println(Math.max(-0.0d, 0.0d));
> prints -0.0 with Harmony and 0.0 with a non-Harmony classlib.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.