You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2024/05/13 17:58:06 UTC
[PR] Use the built-in crypto:pbkdf2_hmac function [couchdb]
nickva opened a new pull request, #5053:
URL: https://github.com/apache/couchdb/pull/5053
The fix to make `crypto:pbkdf2_hmac/5` yield properly is now in all the supported Erlang/OTP versions, so we can switch to use it [1].
This also removes the build dependency on OpenSSL dev package.
[1] https://github.com/erlang/otp/pull/8174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the built-in crypto:pbkdf2_hmac function [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5053:
URL: https://github.com/apache/couchdb/pull/5053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the built-in crypto:pbkdf2_hmac function [couchdb]
Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #5053:
URL: https://github.com/apache/couchdb/pull/5053#discussion_r1598887861
##########
rebar.config.script:
##########
@@ -80,9 +80,15 @@ BadErlang = fun(Ver) ->
end
end.
+% crypto:pbkdf2_hmac/5 was blocking schedulers in
+% versions < 24.3.4.17, < 25.3.2.10 and < 26.2.3
+%
case VerList of
% Leave example around if we have to exlude specific versions
% [22, 0, N | _] when N < 5 -> BadErlang(VerString);
+ [24, 3, 4, N | _] when N < 17 -> BadErlang(VerString);
+ [25, 3, 2, N | _] when N < 10 -> BadErlang(VerString);
+ [26, 2, N | _] when N < 3 -> BadErlang(VerString);
Review Comment:
This is super helpful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org