You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia <vi...@yahoo.com> on 2017/01/13 16:46:35 UTC
Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
Bugs: AMBARI-19524
https://issues.apache.org/jira/browse/AMBARI-19524
Repository: ambari
Description
-------
Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
Diffs
-----
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py 1fd1b9b
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py f2fec70
ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d
Diff: https://reviews.apache.org/r/55505/diff/
Testing
-------
Verified fresh installation on centos-6.
Thanks,
Vishal Suvagia
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review163539
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 27, 2017, 3:05 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 3:05 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 8ae6469
>
> Diff: https://reviews.apache.org/r/55505/diff/
>
>
> Testing
> -------
>
> Verified fresh installation on centos-6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Vishal Suvagia <vi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 3:05 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
Changes
-------
Made changes as suggested to remove hard-coding of specifics stack in tests
Bugs: AMBARI-19524
https://issues.apache.org/jira/browse/AMBARI-19524
Repository: ambari
Description
-------
Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
Diffs (updated)
-----
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 8ae6469
Diff: https://reviews.apache.org/r/55505/diff/
Testing
-------
Verified fresh installation on centos-6.
Thanks,
Vishal Suvagia
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review162549
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Jan. 13, 2017, 4:46 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 4:46 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py 1fd1b9b
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py f2fec70
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d
>
> Diff: https://reviews.apache.org/r/55505/diff/
>
>
> Testing
> -------
>
> Verified fresh installation on centos-6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review162682
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py (line 35)
<https://reviews.apache.org/r/55505/#comment234026>
Even in unit tests, don't hardcode /usr/hdp/
- Alejandro Fernandez
On Jan. 13, 2017, 4:46 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 4:46 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py 1fd1b9b
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py f2fec70
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d
>
> Diff: https://reviews.apache.org/r/55505/diff/
>
>
> Testing
> -------
>
> Verified fresh installation on centos-6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Vishal Suvagia <vi...@yahoo.com>.
> On Jan. 25, 2017, 10:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py, line 35
> > <https://reviews.apache.org/r/55505/diff/1/?file=1604868#file1604868line35>
> >
> > You can retrieve the stack root from the cluster-env config, store it in a variable and just reference it.
Thank you Alejandro, fixed the same in attached patch.
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review163028
-----------------------------------------------------------
On Jan. 27, 2017, 3:05 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 3:05 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 8ae6469
>
> Diff: https://reviews.apache.org/r/55505/diff/
>
>
> Testing
> -------
>
> Verified fresh installation on centos-6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 55505: AMBARI-19524 : Use stack-level Atlas conf
directory instead of hard-coded /etc/atlas/conf path
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55505/#review163028
-----------------------------------------------------------
ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py (line 35)
<https://reviews.apache.org/r/55505/#comment234429>
You can retrieve the stack root from the cluster-env config, store it in a variable and just reference it.
- Alejandro Fernandez
On Jan. 13, 2017, 4:46 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55505/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 4:46 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19524
> https://issues.apache.org/jira/browse/AMBARI-19524
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Hardcoding Atlas conf_dir path does lead to Upgrade Downgrade scenarios, need to update Atlac Conf path as per stack structures
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py 1fd1b9b
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py f2fec70
> ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d
>
> Diff: https://reviews.apache.org/r/55505/diff/
>
>
> Testing
> -------
>
> Verified fresh installation on centos-6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>