You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/07/09 11:01:37 UTC
[jira] [Created] (BOOKKEEPER-334) client-side message filter for
java client.
Sijie Guo created BOOKKEEPER-334:
------------------------------------
Summary: client-side message filter for java client.
Key: BOOKKEEPER-334
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
Project: Bookkeeper
Issue Type: Sub-task
Components: hedwig-client
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.2.0
Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447321#comment-13447321 ]
Hudson commented on BOOKKEEPER-334:
-----------------------------------
Integrated in bookkeeper-trunk #687 (See [https://builds.apache.org/job/bookkeeper-trunk/687/])
BOOKKEEPER-334: client-side message filter for java client. (sijie via ivank) (Revision 1380268)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/FilterableMessageHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/filter/ClientMessageFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/filter/MessageFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/filter/MessageFilterBase.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/filter/PipelineFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/filter/ServerMessageFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/protobuf/PubSubProtocol.proto
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AllToAllTopologyFilter.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestBackwardCompat.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/filter/TestMessageFilter.java
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-334:
---------------------------------
Attachment: BOOKKEEPER-334.patch
attach a new patch to run message filter in client-side. the patch is generated based on BOOKKEEPER-333.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-334:
---------------------------------
Attachment: BOOKKEEPER-334.patch
attach a new patch addressing Ivan's comments.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410442#comment-13410442 ]
Sijie Guo commented on BOOKKEEPER-334:
--------------------------------------
the patch is generated based on BOOKKEEPER-333.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-334:
---------------------------------
Attachment: BOOKKEEPER-334.patch
rebase the patch to latest trunk after BOOKKEEPER-371 is in.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445794#comment-13445794 ]
Ivan Kelly commented on BOOKKEEPER-334:
---------------------------------------
I think startDeliveryWithFilter would be a better name.
There's new functionallity which replaces the provided subscriptionpreferences which that on the server. This should be documented in the javadoc, that any SubscriptionPreferences specified for an ATTACH will be be ignored in favour of those specified in the first CREATE.
What is the usecase? Why is this necessary if there are filters on the server?
startDelivery should throw an exception if messageFilter or messageHandler is null.
Otherwise, the patch looks good.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445798#comment-13445798 ]
Ivan Kelly commented on BOOKKEEPER-334:
---------------------------------------
Also, I think it would be better to change the filter class hierarchy a bit, to make it clear if a filter can be serverside, clientside or both. So have
{code}
interface MessageFilterBase {
public MessageFilter setSubscriptionPreferences(ByteString topic, ByteString subscriberId,
SubscriptionPreferences preferences);
public boolean testMessage(Message message);
}
interface ClientMessageFilter extends MessageFilterBase {
}
interface ServerMessageFilter extends MessageFilterBase {
ServerMessageFilter initialize(Configuration conf);
void uninitialized();
}
{code}
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch, BOOKKEEPER-334.patch, BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-334) client-side message filter for
java client.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-334:
---------------------------------
Attachment: BOOKKEEPER-334.patch
attach the draft patch to run client-side filter on java client.
> client-side message filter for java client.
> -------------------------------------------
>
> Key: BOOKKEEPER-334
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-334
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-client
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-334.patch
>
>
> Support running message filter on java client-side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira