You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/30 04:57:03 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31996: [SPARK-34896][SQL] Return day-time interval from dates subtraction

AngersZhuuuu commented on a change in pull request #31996:
URL: https://github.com/apache/spark/pull/31996#discussion_r603781518



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2350,6 +2350,13 @@ object SQLConf {
     .booleanConf
     .createWithDefault(false)
 
+  val ANSI_INTERVALS_ENABLED = buildConf("spark.sql.ansi.intervals.enabled")

Review comment:
       +1, Looks like only spark have type  `CalendarIntervalType`. In other engine like hive, presto etc, they use day time interval and year month interval too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org