You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2009/08/12 14:13:59 UTC
svn commit: r803469 -
/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java
Author: jacopoc
Date: Wed Aug 12 12:13:58 2009
New Revision: 803469
URL: http://svn.apache.org/viewvc?rev=803469&view=rev
Log:
Slightly better error handling: at least now the xml error message response from eBay is printed in the screen, instead of the "Items published successfully" message.
Modified:
ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java
Modified: ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java?rev=803469&r1=803468&r2=803469&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java (original)
+++ ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ProductsExportToEbay.java Wed Aug 12 12:13:58 2009
@@ -56,6 +56,7 @@
public static Map exportToEbay(DispatchContext dctx, Map context) {
Locale locale = (Locale) context.get("locale");
+ Map result = null;
try {
String configString = "ebayExport.properties";
@@ -91,16 +92,25 @@
*/
if (!ServiceUtil.isFailure(buildDataItemsXml(dctx, context, dataItemsXml, token))) {
- Map result = postItem(xmlGatewayUri, dataItemsXml, devID, appID, certID, "AddItem", compatibilityLevel, siteID);
+ result = postItem(xmlGatewayUri, dataItemsXml, devID, appID, certID, "AddItem", compatibilityLevel, siteID);
if (ServiceUtil.isFailure(result)) {
return ServiceUtil.returnFailure(ServiceUtil.getErrorMessage(result));
}
+ } else {
+ return ServiceUtil.returnFailure(UtilProperties.getMessage(resource, "productsExportToEbay.exceptionInExportToEbay", locale));
}
} catch (Exception e) {
Debug.logError("Exception in exportToEbay " + e, module);
return ServiceUtil.returnFailure(UtilProperties.getMessage(resource, "productsExportToEbay.exceptionInExportToEbay", locale));
}
- return ServiceUtil.returnSuccess(UtilProperties.getMessage(resource, "productsExportToEbay.productItemsSentToEbay", locale));
+ String successMessage = UtilProperties.getMessage(resource, "productsExportToEbay.productItemsSentToEbay", locale);
+ if (result != null) {
+ String responseString = (String)result.get("successMessage");
+ if (UtilValidate.isNotEmpty(responseString)) {
+ successMessage = responseString;
+ }
+ }
+ return ServiceUtil.returnSuccess(successMessage);
}
private static void appendRequesterCredentials(Element elem, Document doc, String token) {
@@ -141,7 +151,6 @@
OutputStream outputStream = connection.getOutputStream();
outputStream.write(dataItems.toString().getBytes());
outputStream.close();
-
int responseCode = connection.getResponseCode();
InputStream inputStream;
Map result = FastMap.newInstance();