You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2006/05/05 17:47:01 UTC
Re: svn commit: r19515 - trunk/subversion/libsvn_fs_base/util
On Thu, 04 May 2006, djames@tigris.org wrote:
...
> Log:
> * subversion/libsvn_fs_base/util/fs_skels.c
> (is_valid_rep_delta_chunk_skel): Update length check to account for the fact
> that the window checksum skel was removed in r7643.
>
> Found by: Coverity <http://scan.coverity.com>
> Coverity ID: 1
...
> Modified: trunk/subversion/libsvn_fs_base/util/fs_skels.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_base/util/fs_skels.c?pathrev=19515&r1=19514&r2=19515
> ==============================================================================
> --- trunk/subversion/libsvn_fs_base/util/fs_skels.c (original)
> +++ trunk/subversion/libsvn_fs_base/util/fs_skels.c Thu May 4 14:04:25 2006
> @@ -135,7 +135,7 @@
> && (window->children->next->is_atom)
> && (window->children->next->next->is_atom)))
> return FALSE;
> - if ((len == 5)
> + if ((len == 4)
> && (! window->children->next->next->next->is_atom))
> return FALSE;
These length checks are scattered all over fs_skels.c. Any particular
reason we're not using a group of constants (or an enum) to describe
skel list elements?
- Dan
Re: svn commit: r19515 - trunk/subversion/libsvn_fs_base/util
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 5/5/06, Daniel Rall <dl...@collab.net> wrote:
> On Thu, 04 May 2006, djames@tigris.org wrote:
> ...
> > Log:
> > * subversion/libsvn_fs_base/util/fs_skels.c
> > (is_valid_rep_delta_chunk_skel): Update length check to account for the fact
> > that the window checksum skel was removed in r7643.
> >
> > Found by: Coverity <http://scan.coverity.com>
> > Coverity ID: 1
> ...
> > Modified: trunk/subversion/libsvn_fs_base/util/fs_skels.c
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_base/util/fs_skels.c?pathrev=19515&r1=19514&r2=19515
> > ==============================================================================
> > --- trunk/subversion/libsvn_fs_base/util/fs_skels.c (original)
> > +++ trunk/subversion/libsvn_fs_base/util/fs_skels.c Thu May 4 14:04:25 2006
> > @@ -135,7 +135,7 @@
> > && (window->children->next->is_atom)
> > && (window->children->next->next->is_atom)))
> > return FALSE;
> > - if ((len == 5)
> > + if ((len == 4)
> > && (! window->children->next->next->next->is_atom))
> > return FALSE;
>
>
> These length checks are scattered all over fs_skels.c. Any particular
> reason we're not using a group of constants (or an enum) to describe
> skel list elements?
That would seem like a reasonable improvement to me.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org