[jira] [Comment Edited] (HIVE-17595) Correct DAG for updating the last.repl.id for a database during bootstrap load

["anishek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226533#comment-16226533 ] 

anishek edited comment on HIVE-17595 at 10/31/17 9:58 AM:
----------------------------------------------------------

* Added a note as to why this change is needed
* changed the class names 
* there is separate conditions that lead to execution of createEndReplLogTask, it is done after all the tasks are done as part of 
{code}
      boolean addAnotherLoadTask = iterator.hasNext() || loadTaskTracker.hasReplicationState()
          || constraintIterator.hasNext();
      createBuilderTask(scope.rootTasks, addAnotherLoadTask);
      if (!iterator.hasNext() && !constraintIterator.hasNext()) {
        loadTaskTracker.update(updateDatabaseLastReplID(maxTasks, context, scope));
        work.updateDbEventState(null);
      }
{code}


was (Author: anishek):
* Added a note as to why this change is needed ?
* changed the file names 
* there is separate conditions that lead to execution of createEndReplLogTask, it is done after all the tasks are done as part of 
{code}
      boolean addAnotherLoadTask = iterator.hasNext() || loadTaskTracker.hasReplicationState()
          || constraintIterator.hasNext();
      createBuilderTask(scope.rootTasks, addAnotherLoadTask);
      if (!iterator.hasNext() && !constraintIterator.hasNext()) {
        loadTaskTracker.update(updateDatabaseLastReplID(maxTasks, context, scope));
        work.updateDbEventState(null);
      }
{code}

> Correct DAG for updating the last.repl.id for a database during bootstrap load
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-17595
>                 URL: https://issues.apache.org/jira/browse/HIVE-17595
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 3.0.0
>            Reporter: anishek
>            Assignee: anishek
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17595.0.patch, HIVE-17595.1.patch, HIVE-17595.2.patch, HIVE-17595.3.patch
>
>
> We update the last.repl.id as a database property. This is done after all the bootstrap tasks to load the relevant data are done and is the last task to be run. however we are currently not setting up the DAG correctly for this task. This is getting added as the root task for now where as it should be the last task to be run in a DAG. This becomes more important after the inclusion of 
> HIVE-17426 since this will lead to parallel execution and incorrect DAG's will lead to incorrect results/state of the system. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)