You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/04/11 14:22:37 UTC

[GitHub] [karaf] oliverlietz opened a new pull request #1346: KARAF-7099 Provide util for Configuration PIDs

oliverlietz opened a new pull request #1346:
URL: https://github.com/apache/karaf/pull/1346


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] oliverlietz commented on a change in pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
oliverlietz commented on a change in pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#discussion_r627345448



##########
File path: util/pom.xml
##########
@@ -74,6 +74,13 @@
             <artifactId>mail</artifactId>
             <scope>test</scope>
         </dependency>
+        <!-- nullability -->
+        <dependency>
+            <groupId>org.jetbrains</groupId>
+            <artifactId>annotations</artifactId>

Review comment:
       In general I prefer to annotate parameters and return values but the dependency is of course not strictly required. The annotations (https://github.com/JetBrains/java-annotations) are used during analysis and compile time only and should have no negative impact.
   Should I remove the annotations from ConfigurationPID?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre closed pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #1346:
URL: https://github.com/apache/karaf/pull/1346


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#issuecomment-834089228


   Superseeded by #1368 1368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre edited a comment on pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre edited a comment on pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#issuecomment-834089228


   Superseeded by #1368 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#issuecomment-817334597


   It would be great to have a quick abstract / description of the PR. Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on a change in pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#discussion_r627225310



##########
File path: util/pom.xml
##########
@@ -74,6 +74,13 @@
             <artifactId>mail</artifactId>
             <scope>test</scope>
         </dependency>
+        <!-- nullability -->
+        <dependency>
+            <groupId>org.jetbrains</groupId>
+            <artifactId>annotations</artifactId>

Review comment:
       Do we really need this dependency in util for null check ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on a change in pull request #1346: KARAF-7099 Provide util for Configuration PIDs

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #1346:
URL: https://github.com/apache/karaf/pull/1346#discussion_r627346297



##########
File path: util/pom.xml
##########
@@ -74,6 +74,13 @@
             <artifactId>mail</artifactId>
             <scope>test</scope>
         </dependency>
+        <!-- nullability -->
+        <dependency>
+            <groupId>org.jetbrains</groupId>
+            <artifactId>annotations</artifactId>

Review comment:
       Don't worry, I'm reworking your two PRs. Thanks !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org