You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ty...@apache.org on 2022/09/04 16:18:30 UTC

[incubator-seatunnel] branch dev updated: [Bug] [connector-jdbc-v2] Fix transaction force commit when autoCommit is enabled (#2636)

This is an automated email from the ASF dual-hosted git repository.

tyrantlucifer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 8cd8cf7aa [Bug] [connector-jdbc-v2] Fix transaction force commit when autoCommit is enabled (#2636)
8cd8cf7aa is described below

commit 8cd8cf7aa2d3a388e4cc7a4bcfc250519800770f
Author: hailin0 <wa...@apache.org>
AuthorDate: Mon Sep 5 00:18:24 2022 +0800

    [Bug] [connector-jdbc-v2] Fix transaction force commit when autoCommit is enabled (#2636)
---
 .../jdbc/internal/executor/SimpleBatchStatementExecutor.java       | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/SimpleBatchStatementExecutor.java b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/SimpleBatchStatementExecutor.java
index 1c96d5c05..02ec08f39 100644
--- a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/SimpleBatchStatementExecutor.java
+++ b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/executor/SimpleBatchStatementExecutor.java
@@ -68,7 +68,9 @@ public class SimpleBatchStatementExecutor<T> implements JdbcBatchStatementExecut
             batch.clear();
 
             // cache commit
-            st.getConnection().commit();
+            if (!st.getConnection().getAutoCommit()) {
+                st.getConnection().commit();
+            }
             st.clearParameters();
             st.clearBatch();
 
@@ -78,6 +80,9 @@ public class SimpleBatchStatementExecutor<T> implements JdbcBatchStatementExecut
     @Override
     public void closeStatements() throws SQLException {
         if (st != null) {
+            if (!st.getConnection().getAutoCommit()) {
+                st.getConnection().commit();
+            }
             st.close();
             st = null;
         }