You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/06 09:49:26 UTC
[GitHub] [superset] geido commented on a diff in pull request #19521: refactor: Removes the CSS files from the Partition plugin
geido commented on code in PR #19521:
URL: https://github.com/apache/superset/pull/19521#discussion_r843735501
##########
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js:
##########
@@ -274,7 +273,7 @@ function Icicle(element, props) {
'<tr>' +
'<td>' +
'<div ' +
- `style='border: 2px solid ${atNode ? 'black' : 'transparent'};` +
+ `style='border: 2px solid ${atNode ? 'white' : 'transparent'};` +
Review Comment:
@michael-s-molina should we use the available white in the theme vars?
##########
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js:
##########
@@ -274,7 +273,7 @@ function Icicle(element, props) {
'<tr>' +
'<td>' +
'<div ' +
- `style='border: 2px solid ${atNode ? 'black' : 'transparent'};` +
+ `style='border: 2px solid ${atNode ? 'white' : 'transparent'};` +
Review Comment:
@michael-s-molina should we use the available white from the theme vars?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org