You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Shohei Okumiya (Jira)" <ji...@apache.org> on 2025/06/03 12:53:00 UTC
[jira] [Resolved] (HIVE-28796) Remove transient from static fields
[ https://issues.apache.org/jira/browse/HIVE-28796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shohei Okumiya resolved HIVE-28796.
-----------------------------------
Fix Version/s: 4.1.0
Resolution: Fixed
I merged this one.
https://github.com/apache/hive/pull/5836
> Remove transient from static fields
> -----------------------------------
>
> Key: HIVE-28796
> URL: https://issues.apache.org/jira/browse/HIVE-28796
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: Raghav Aggarwal
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.1.0
>
>
> In case of static fields, transient is not needed (static fields are not serialized anyway). We use this pattern for Tasks extensively.
> {code}
> grep -iRH "transient.*Logger" --include="*.java"
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java: private static transient final Logger LOG = LoggerFactory.getLogger(HiveOnTezCostModel.class);
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java: private static transient final Logger LOG = LoggerFactory.getLogger(HiveJoinToMultiJoinRule.class);
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MemoryDecider.java: protected static transient final Logger LOG = LoggerFactory.getLogger(MemoryDecider.class);
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CrossProductHandler.java: protected static transient final Logger LOG = LoggerFactory
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapPreVectorizationPass.java: protected static transient final Logger LOG = LoggerFactory.getLogger(LlapPreVectorizationPass.class);
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SerializeFilter.java: protected static transient final Logger LOG = LoggerFactory.getLogger(SerializeFilter.class);
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java: protected static transient final Logger LOG = LoggerFactory.getLogger(LlapDecider.class);
> ql/src/java/org/apache/hadoop/hive/ql/plan/TezWork.java: private static transient final Logger LOG = LoggerFactory.getLogger(TezWork.class);
> ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java: private static transient Logger LOG = LoggerFactory.getLogger(SyntheticJoinPredicate.class.getName());
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java: protected static transient final Logger LOG = LoggerFactory.getLogger(ExecDriver.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java: public static transient final Logger l4j = LoggerFactory.getLogger(MapredLocalTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java: private static transient final Logger LOG = LoggerFactory.getLogger(TaskRunner.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java: protected transient final Logger LOG = LoggerFactory.getLogger(getClass().getName());
> ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java: private static transient final Logger LOG = LoggerFactory.getLogger(StatsTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasLoadTask.java: private static final transient Logger LOG = LoggerFactory.getLogger(AtlasLoadTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/RangerDumpTask.java: private transient ReplLogger replLogger;
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/load/LoadDatabase.java: protected static transient Logger LOG = LoggerFactory.getLogger(LoadDatabase.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java: private static transient Logger LOG = LoggerFactory.getLogger(ReplUtils.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/SnapshotUtils.java: private static final transient Logger LOG = LoggerFactory.getLogger(SnapshotUtils.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java: private static final transient Logger LOG = LoggerFactory.getLogger(AtlasDumpTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplicationMigrationTool.java: protected static transient Logger LOG = LoggerFactory.getLogger(ReplicationMigrationTool.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/repl/RangerLoadTask.java: private transient ReplLogger replLogger;
> ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java: private static transient final Logger LOG = LoggerFactory.getLogger(MoveTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java: private static transient Logger LOG = LoggerFactory.getLogger(CLASS_NAME);
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/PerPoolTriggerValidatorRunnable.java: protected static transient Logger LOG = LoggerFactory.getLogger(PerPoolTriggerValidatorRunnable.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TriggerValidatorRunnable.java: protected static transient Logger LOG = LoggerFactory.getLogger(TriggerValidatorRunnable.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java: private static transient final Logger LOG = LoggerFactory
> ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java: private transient final PerfLogger perfLogger = SessionState.getPerfLogger();
> ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java: protected static transient final Logger LOG = LoggerFactory.getLogger(OperatorFactory.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java: protected static transient Logger LOG = LoggerFactory.getLogger(Task.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java: private static transient final Logger LOG = LoggerFactory.getLogger(ReplCopyTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java: protected transient final Logger LOG = LoggerFactory.getLogger(getClass().getName());
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorCopyRow.java: protected static transient final Logger LOG = LoggerFactory.getLogger(VectorCopyRow.class);
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnOrderedMap.java: protected static transient final Logger LOG = LoggerFactory.getLogger(VectorColumnOrderedMap.class);
> ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsNoJobTask.java: private static transient final Logger LOG = LoggerFactory.getLogger(BasicStatsNoJobTask.class);
> ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java: private static transient final Logger LOG = LoggerFactory.getLogger(ColStatsProcessor.class);
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)