You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/22 10:34:00 UTC

[jira] [Commented] (KAFKA-3881) Remove the replacing logic from "." to "_" in Fetcher

    [ https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059130#comment-16059130 ] 

ASF GitHub Bot commented on KAFKA-3881:
---------------------------------------

GitHub user tombentley opened a pull request:

    https://github.com/apache/kafka/pull/3407

    KAFKA-3881: Remove the replacing logic from "." to "_" in Fetcher

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tombentley/kafka KAFKA-3881

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3407
    
----
commit be0de3a22b30648e2c811ee1442145702024af7a
Author: Tom Bentley <tb...@redhat.com>
Date:   2017-06-22T10:28:58Z

    KAFKA-3881: Remove the replacing logic from "." to "_" in Fetcher

----


> Remove the replacing logic from "." to "_" in Fetcher
> -----------------------------------------------------
>
>                 Key: KAFKA-3881
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3881
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer, metrics
>            Reporter: Guozhang Wang
>              Labels: newbie, patch-available
>
> The logic of replacing "." to "_" in metrics names / tags was originally introduced in the core package's metrics since Graphite treats "." as hierarchy separators (see KAFKA-1902); for the client metrics, it is supposed that the GraphiteReported should take care of this itself rather than letting Kafka metrics to special handle for it. In addition, right now only consumer Fetcher had replace, but producer Sender does not have it actually.
> So we should consider removing this logic in the consumer Fetcher's metrics package. NOTE that this is a public API backward incompatible change.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)