You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/02 01:03:23 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #18464: [v1.7] Cherry-pick #17776 #17681
mseth10 opened a new pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464
## Description ##
Cherry-pick #17776 #17681 to update PyPI description
Fixes #18462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-641318329
Thanks @mseth10 for the backport.
Ping @TaoLv , @pengzhao-intel , @leezu to have a review and help merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637348360
@mxnet-bot run ci [unix-gpu, miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#discussion_r434741761
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
+libmxnet = 'build/libmxnet.so'
Review comment:
@mseth10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#discussion_r434126818
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
+libmxnet = 'build/libmxnet.so'
Review comment:
This is for switching to the cmake build on CD. Should it be done separately / only for 1.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637348978
Jenkins CI successfully triggered : [unix-gpu, website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637348432
Jenkins CI successfully triggered : [miscellaneous, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637696089
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 edited a comment on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 edited a comment on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637348360
@mxnet-bot run ci [unix-gpu, website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#discussion_r436242114
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
+libmxnet = 'build/libmxnet.so'
Review comment:
Reverted this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-640510323
@mxnet-bot run ci [unix-cpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-640510366
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637206652
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, centos-gpu, miscellaneous, centos-cpu, windows-gpu, unix-gpu, clang, windows-cpu, sanity, unix-cpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-637696150
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-640737348
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-640937543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18464: [v1.7] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18464:
URL: https://github.com/apache/incubator-mxnet/pull/18464#issuecomment-640737386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org