[GitHub] [openwhisk] ningyougang commented on a change in pull request #4911: take prewarmed container's memory as used memory

[GitBox <gi...@apache.org>]

ningyougang commented on a change in pull request #4911:
URL: https://github.com/apache/openwhisk/pull/4911#discussion_r485277193



##########
File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -131,9 +131,18 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
           //remove from resent tracking - it may get resent again, or get processed
           resent = None
         }
+        val kind = r.action.exec.kind
+        val memory = r.action.limits.memory.megabytes.MB
+
+        val prewarmedPoolForOtherKind = prewarmedPool.filter { info =>
+          info match {
+            case (_, PreWarmedData(_, `kind`, `memory`, _, _)) => false

Review comment:
       hm.. i forgot the reason why i want to `get the other kind/memory prewarmpool` ,
   but then, i feel use `prewarmedPool` directly is more nature, already updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org