You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/03/26 06:28:57 UTC

[kudu-CR] test result server: better error when AWS variables aren't set 

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12854

to review the following change.


Change subject: test_result_server: better error when AWS variables aren't set
......................................................................

test_result_server: better error when AWS variables aren't set

Better to raise a KeyError than to see an inscrutable error somewhere deep in
the boto module.

Change-Id: I38c155c009abea6680a8fc04e2099570b6318394
---
M build-support/test_result_server.py
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/12854/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c155c009abea6680a8fc04e2099570b6318394
Gerrit-Change-Number: 12854
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] test result server: better error when AWS variables aren't set

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12854 )

Change subject: test_result_server: better error when AWS variables aren't set
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38c155c009abea6680a8fc04e2099570b6318394
Gerrit-Change-Number: 12854
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 26 Mar 2019 13:37:05 +0000
Gerrit-HasComments: No

[kudu-CR] test result server: better error when AWS variables aren't set

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12854 )

Change subject: test_result_server: better error when AWS variables aren't set
......................................................................

test_result_server: better error when AWS variables aren't set

Better to raise a KeyError than to see an inscrutable error somewhere deep in
the boto module.

Change-Id: I38c155c009abea6680a8fc04e2099570b6318394
Reviewed-on: http://gerrit.cloudera.org:8080/12854
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/test_result_server.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38c155c009abea6680a8fc04e2099570b6318394
Gerrit-Change-Number: 12854
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>