You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/19 23:19:55 UTC

[GitHub] [helix] dasahcc commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation

dasahcc commented on a change in pull request #851: Modify Helix generic controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r395371018
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -775,6 +811,38 @@ public void onStateChange(String instanceName, List<CurrentState> statesInfo,
     logger.info("END: GenericClusterController.onStateChange()");
   }
 
+  @Override
 
 Review comment:
   Prefetch ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org