You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2026/09/26 08:03:09 UTC
[PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
hainenber opened a new pull request, #44696:
URL: https://github.com/apache/superset/pull/44696
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
chore(ci): configure more grouped dep upgrades across npm subprojects
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
First commit is to fix issue whereby CodeQL workflows fail due to version mismatch for its required actions
<img width="1161" height="565" alt="image" src="https://github.com/user-attachments/assets/6b9ce2ea-0e75-4018-8850-2d515e1a29e8" />
Second commit is to have more grouped Dependabot PRs for sub-projects, reducing further CI compute time.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Green CI for acceptance criterion.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4133037148
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: main
Review Comment:
Dependency updates for `/superset-frontend`, `/superset-embedded-sdk`, `/superset-websocket`, and `/docs` would silently stop — `target-branch: main` points at a branch that doesn't exist in this repo (default branch is `master`; `gh api repos/apache/superset/branches/main` returns 404). Dependabot aborts the whole update job when the target branch is missing, and that failure only shows up in the repo's Insights → Dependabot tab, not in this PR's CI. Should this be `target-branch: master`, or does the multiple-configs workaround need a different value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44696:
URL: https://github.com/apache/superset/pull/44696#issuecomment-5889633773
<!-- Bito Reply -->
You are correct. If the `main` branch does not exist in the repository, Dependabot will fail to process the configuration, and this failure is often not surfaced in the PR's CI checks. Since the default branch for this repository is `master`, you should update `target-branch: main` to `target-branch: master` in `.github/dependabot.yml` to ensure the configuration is valid and Dependabot can successfully track the dependencies.
**.github/dependabot.yml**
```
# Hack to allow multiple configs for the same ecosystem/directory combination
# See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
target-branch: master
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4139907469
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: master
Review Comment:
This makes the root npm configuration apply only to version updates, so its `security` group no longer governs security updates for these directories. A batch of frontend alerts will now arrive as separate PRs rather than the configured grouped update. Could the multiple-config workaround avoid `target-branch`, or could security-update grouping be configured separately?
##########
.github/dependabot.yml:
##########
@@ -49,7 +55,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
These directories are still covered by their own npm update entries later in the file, so Dependabot now has overlapping npm configurations for the same target branch. That can create competing or duplicate version-update PRs for the same manifest. Should the dedicated entries be removed or the multi-directory entry be limited to non-overlapping paths?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4175933884
##########
.github/dependabot.yml:
##########
@@ -95,6 +107,21 @@ updates:
fontsource:
patterns:
- "@fontsource/*"
+ docusaurus:
+ patterns:
+ - "@docusaurus/*"
+ docusaurus-openapi:
+ patterns:
+ - "docusaurus-plugin-openapi-docs"
+ - "docusaurus-theme-openapi-docs"
+ monorepo-dependencies:
+ group-by: dependency-name
+ patterns:
+ - "webpack"
+ - "@types/node"
+ - "oxfmt"
+ - "oxlint"
+ - "oxlint-tsgolint"
open-pull-requests-limit: 30
Review Comment:
Yes, I've reduced the limit to 10 in 5fb0e7eca8d95c3e5c482355e078b97ae9a4e1c1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4147805206
##########
.github/dependabot.yml:
##########
@@ -95,6 +107,21 @@ updates:
fontsource:
patterns:
- "@fontsource/*"
+ docusaurus:
+ patterns:
+ - "@docusaurus/*"
+ docusaurus-openapi:
+ patterns:
+ - "docusaurus-plugin-openapi-docs"
+ - "docusaurus-theme-openapi-docs"
+ monorepo-dependencies:
+ group-by: dependency-name
+ patterns:
+ - "webpack"
+ - "@types/node"
+ - "oxfmt"
+ - "oxlint"
+ - "oxlint-tsgolint"
open-pull-requests-limit: 30
Review Comment:
Merging these four directories into one `directories:` entry doesn't turn `open-pull-requests-limit: 30` into a shared cap — Dependabot applies it independently per directory (reproduced in dependabot/dependabot-core#10395: 26 directories with `limit: 10` produced 26 simultaneous open PRs, one per directory). That raises `/docs` from 10 to 30 and `/superset-websocket`/`/superset-embedded-sdk` from Dependabot's documented default of 5 to 30 each, working against the goal of reducing CI load. Should each directory keep closer to its original narrower limit instead?
##########
.github/dependabot.yml:
##########
@@ -49,7 +52,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
This entry's `ignore:` block was written for superset-frontend's specific constraints (e.g. holding React majors until the app supports React 19, holding Babel 8 for frontend plugin compatibility), but now also covers `/docs` and `/superset-embedded-sdk` since they share this entry. `/docs` (React/React DOM ^18.3.1) had no prior ignore list and could previously receive a React-major update; `/superset-embedded-sdk` (@babel/core already ^8.0.5) had no prior Babel ignore. Both will now silently skip major updates they were previously eligible for, for reasons that don't apply to them. Should the ignore list stay scoped to `/superset-frontend`, or is broadening it to all four intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4145184440
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: master
Review Comment:
All overlapping `npm`-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/pull/44696/commits/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
##########
.github/dependabot.yml:
##########
@@ -49,7 +55,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
All overlapping `npm`-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/pull/44696/commits/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44696:
URL: https://github.com/apache/superset/pull/44696#issuecomment-5871863932
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 71aa3de9414e49a5fea3aad8e97e6f1a92d53d10 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aba7743b9d67800085609d2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44696--superset-docs-preview.netlify.app](https://deploy-preview-44696--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcsxDsIwDEDRu3hupKhA0nIDjmHHEQi1tWWnA0LcHW9_-O8LarLrgDvABGR4tFc0d-0HI8lIap6eJqd2TthM3JOfFOrd2_BA8W7yeXCwgoS1Xi-0cqlLznm5lbzyDL8_) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44696--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4175926219
##########
.github/dependabot.yml:
##########
@@ -49,7 +52,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
It's actually intentional, as we'll have less divergence on dep constraints across all directories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4145206914
##########
.github/dependabot.yml:
##########
@@ -49,7 +55,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
All overlapping npm-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/commit/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: master
Review Comment:
All overlapping npm-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/commit/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44696:
URL: https://github.com/apache/superset/pull/44696#issuecomment-5844462777
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4145206914
##########
.github/dependabot.yml:
##########
@@ -49,7 +55,11 @@ updates:
# hold comments). Remove this once the proxy code is updated to await
# the async decompress() API.
- dependency-name: "simple-zstd"
- directory: "/superset-frontend/"
+ directories:
Review Comment:
All overlapping npm-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/commit/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: master
Review Comment:
All overlapping npm-based Dependabot configs with overlapping directories gets merged in https://github.com/apache/superset/commit/be0bb512b96013d3cebb575082fcd8d59fa3ed2b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4134774365
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: main
Review Comment:
Ah right, my bad. That was copied straight up from the GH issue comment 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #44696:
URL: https://github.com/apache/superset/pull/44696#discussion_r4134797198
##########
.github/dependabot.yml:
##########
@@ -9,10 +9,16 @@ updates:
security:
applies-to: "security-updates"
patterns: ["*"]
+ codeql:
+ patterns:
+ - github/codeql-action/*
cooldown:
default-days: 7
- package-ecosystem: "npm"
+ # Hack to allow multiple configs for the same ecosystem/directory combination
+ # See https://github.com/dependabot/dependabot-core/issues/1778#issuecomment-1988140219
+ target-branch: main
Review Comment:
Resolved in https://github.com/apache/superset/pull/44696/commits/d678d6b8ad2b3db97af19943e21e80bd6f62013f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(ci): configure more grouped dep upgrades across npm subprojects [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #44696:
URL: https://github.com/apache/superset/pull/44696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org